MD Settings: Expanding cards should not overlap header, take 2.

MD Settings: Expanding cards should not overlap header, take 2.

Set the appropriate z-indices such that the paper-toolbar is always on top
of the sections, the backdrop is always on top of the paper-toolbar, and the
dialog is always on top of everything.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ef92223c26ba130d26db80088c8a8e47324d6ad3
Cr-Commit-Position: refs/heads/master@{#394471}

[michaelpg, 2016-05-17 23:37:59]

Description was changed from

==========
MD Settings: Expanding cards should not overlap header, take 2.

Set the appropriate z-indices such that the paper-toolbar is always on top
of the sections, the backdrop is always on top of the paper-toolbar, and the
dialog is always on top of everything.

BUG=589681
R=dbeam@chromium.org
==========

to

==========
MD Settings: Expanding cards should not overlap header, take 2.

Set the appropriate z-indices such that the paper-toolbar is always on top
of the sections, the backdrop is always on top of the paper-toolbar, and the
dialog is always on top of everything.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-17 23:52:40]

PTAL, things work now and I understand why.

[Dan Beam, 2016-05-18 00:27:32]

rs lgtm

and you're right: I did not want to read you proof

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:13: */
/* Must be lower than the paper-header-panel's z-index.
 * See settings_ui.html. */

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:130: *
non-marvellous proof of this, which this comment cannot contain:
cute

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:132: */
/* These ...
^^
 * https://goo.gl/CCzijE */
                         ^^

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:146: */
same formatting nit

[michaelpg, 2016-05-18 16:58:21]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-18 16:58:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1992563002/#ps20001
(title: "formatting")

[michaelpg, 2016-05-18 16:58:26]

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:13: */
On 2016/05/18 00:27:32, Dan Beam wrote:
> /* Must be lower than the paper-header-panel's z-index.
>  * See settings_ui.html. */

Done.

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:132: */
On 2016/05/18 00:27:32, Dan Beam wrote:
> /* These ...
> ^^
>  * https://goo.gl/CCzijE */
>                          ^^

Done.

https://codereview.chromium.org/1992563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_ui/settings_ui.html:146: */
On 2016/05/18 00:27:32, Dan Beam wrote:
> same formatting nit

Done.

[commit-bot: I haz the power, 2016-05-18 16:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992563002/20001

[commit-bot: I haz the power, 2016-05-18 17:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 17:04:05]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[michaelpg, 2016-05-18 17:06:02]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-05-18 17:06:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992563002/20001

[commit-bot: I haz the power, 2016-05-18 17:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 17:12:17]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[michaelpg, 2016-05-18 18:00:07]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-05-18 18:00:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992563002/20001

[commit-bot: I haz the power, 2016-05-18 18:14:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 18:15:58]

Description was changed from

==========
MD Settings: Expanding cards should not overlap header, take 2.

Set the appropriate z-indices such that the paper-toolbar is always on top
of the sections, the backdrop is always on top of the paper-toolbar, and the
dialog is always on top of everything.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Expanding cards should not overlap header, take 2.

Set the appropriate z-indices such that the paper-toolbar is always on top
of the sections, the backdrop is always on top of the paper-toolbar, and the
dialog is always on top of everything.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ef92223c26ba130d26db80088c8a8e47324d6ad3
Cr-Commit-Position: refs/heads/master@{#394471}
==========

[commit-bot: I haz the power, 2016-05-18 18:15:59]

Patchset 2 (id:??) landed as
https://crrev.com/ef92223c26ba130d26db80088c8a8e47324d6ad3
Cr-Commit-Position: refs/heads/master@{#394471}