Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 1992563002: MD Settings: Expanding cards should not overlap header, take 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui.html
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.html b/chrome/browser/resources/settings/settings_ui/settings_ui.html
index 5b527c4daa56bee2d7ab01adcd03076d8d3564ab..5c58e292599146dd0826e210354a24127b9d9a59 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.html
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.html
@@ -119,6 +119,33 @@
--paper-input-max-width: 200px;
}
+ /* These header elements must create stacking contexts when a section is
+ * expanding to show a sub-page. (It's simpler for them to always create
+ * these stacking contexts, so we do.) But for the overlay to work, the
+ * paper-header-panel's other descendents (rooted at settings-main) must
+ * never create stacking contexts while a dialog is showing. This means
+ * we cannot animate a section expanding/collapsing while a dialog is
+ * shown (which makes good UX sense anyway.) I have discovered a truly
+ * non-marvellous proof of this, which this comment cannot contain:
+ * https://goo.gl/CCzijE */
+ paper-header-panel[main] paper-toolbar {
+ z-index: 2;
+ }
+
+ paper-header-panel[main] {
+ --paper-header-panel-shadow: {
+ z-index: 2;
+ };
+ }
+
+ /* The paper-drawer-panel implementation gives the drawer a stacking
+ * context, so its z-index should at least equal the main panel's. */
+ paper-drawer-panel[narrow] {
+ --paper-drawer-panel-drawer-container: {
+ z-index: 2;
+ };
+ }
+
paper-toolbar {
--paper-toolbar-height: 56px;
--paper-toolbar-sm-height: 56px;
« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698