Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 1992563002: MD Settings: Expanding cards should not overlap header, take 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-drawer-panel/pape r-drawer-panel.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-drawer-panel/pape r-drawer-panel.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-header-panel/pape r-header-panel.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-header-panel/pape r-header-panel.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toolbar/paper-too lbar.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toolbar/paper-too lbar.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
10 <link rel="import" href="chrome://md-settings/direction_delegate.html"> 10 <link rel="import" href="chrome://md-settings/direction_delegate.html">
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 top: 4px; 112 top: 4px;
113 }; 113 };
114 --paper-input-container-input-color: var(--settings-title-bar-color); 114 --paper-input-container-input-color: var(--settings-title-bar-color);
115 --paper-input-container-label: { 115 --paper-input-container-label: {
116 font-size: 81.25%; /* go to 13px from 16px */ 116 font-size: 81.25%; /* go to 13px from 16px */
117 top: 3px; /* Special positioning needed for UX design. */ 117 top: 3px; /* Special positioning needed for UX design. */
118 }; 118 };
119 --paper-input-max-width: 200px; 119 --paper-input-max-width: 200px;
120 } 120 }
121 121
122 /*
123 * These header elements must create stacking contexts when a section is
124 * expanding to show a sub-page. (It's simpler for them to always create
125 * these stacking contexts, so we do.) But for the overlay to work, the
126 * paper-header-panel's other descendents (rooted at settings-main) must
127 * never create stacking contexts while a dialog is showing. This means
128 * we cannot animate a section expanding/collapsing while a dialog is
129 * shown (which makes good UX sense anyway.) I have discovered a truly
130 * non-marvellous proof of this, which this comment cannot contain:
Dan Beam 2016/05/18 00:27:32 cute
131 * https://goo.gl/CCzijE
132 */
Dan Beam 2016/05/18 00:27:32 /* These ... ^^ * https://goo.gl/CCzijE */
michaelpg 2016/05/18 16:58:26 Done.
133 paper-header-panel[main] paper-toolbar {
134 z-index: 2;
135 }
136
137 paper-header-panel[main] {
138 --paper-header-panel-shadow: {
139 z-index: 2;
140 };
141 }
142
143 /*
144 * The paper-drawer-panel implementation gives the drawer a stacking
145 * context, so its z-index should at least equal the main panel's.
146 */
Dan Beam 2016/05/18 00:27:32 same formatting nit
michaelpg 2016/05/18 16:58:26 Done.
147 paper-drawer-panel[narrow] {
148 --paper-drawer-panel-drawer-container: {
149 z-index: 2;
150 };
151 }
152
122 paper-toolbar { 153 paper-toolbar {
123 --paper-toolbar-height: 56px; 154 --paper-toolbar-height: 56px;
124 --paper-toolbar-sm-height: 56px; 155 --paper-toolbar-sm-height: 56px;
125 --paper-toolbar-content: { 156 --paper-toolbar-content: {
126 font-size: 123.08%; /* go to 16px from 13px */ 157 font-size: 123.08%; /* go to 16px from 13px */
127 }; 158 };
128 --paper-toolbar: { 159 --paper-toolbar: {
129 background-color: var(--settings-title-bar-background-color); 160 background-color: var(--settings-title-bar-background-color);
130 }; 161 };
131 } 162 }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 </paper-input> 218 </paper-input>
188 </div> 219 </div>
189 </paper-toolbar> 220 </paper-toolbar>
190 <settings-main prefs="{{prefs}}" current-route="{{currentRoute}}"> 221 <settings-main prefs="{{prefs}}" current-route="{{currentRoute}}">
191 </settings-main> 222 </settings-main>
192 </paper-header-panel> 223 </paper-header-panel>
193 </paper-drawer-panel> 224 </paper-drawer-panel>
194 </template> 225 </template>
195 <script src="settings_ui.js"></script> 226 <script src="settings_ui.js"></script>
196 </dom-module> 227 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698