Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1991833002: Fix use_icu_data_file. (Closed)

Created:
4 years, 7 months ago by altimin
Modified:
4 years, 7 months ago
CC:
alex clarke (OOO till 29th), chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
altimin
4 years, 7 months ago (2016-05-18 15:51:20 UTC) #4
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-18 16:00:01 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 7 months ago (2016-05-18 16:11:06 UTC) #7
Sami
Committed patchset #1 (id:1) manually as d9f48be67ba790adbc59d3ab195b2d8278c9d73b (presubmit successful).
4 years, 7 months ago (2016-05-18 16:19:31 UTC) #9
jungshik at Google
4 years, 7 months ago (2016-05-18 21:11:13 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1991833002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1991833002/diff/1/BUILD.gn#newcode45
BUILD.gn:45: }
didn't realize that BUILD.gn does not have these defined. Thanks.

Powered by Google App Engine
This is Rietveld 408576698