Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: BUILD.gn

Issue 1991833002: Fix use_icu_data_file. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 public_deps = [ 10 public_deps = [
(...skipping 15 matching lines...) Expand all
26 ] 26 ]
27 27
28 if (!is_component_build) { 28 if (!is_component_build) {
29 defines += [ "U_STATIC_IMPLEMENTATION" ] 29 defines += [ "U_STATIC_IMPLEMENTATION" ]
30 } 30 }
31 31
32 include_dirs = [ 32 include_dirs = [
33 "source/common", 33 "source/common",
34 "source/i18n", 34 "source/i18n",
35 ] 35 ]
36
37 if (icu_use_data_file) {
38 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
39 } else {
40 if (is_win) {
41 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]
42 } else {
43 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]
44 }
45 }
jungshik at Google 2016/05/18 21:11:13 didn't realize that BUILD.gn does not have these d
36 } 46 }
37 47
38 # Config used only by ICU code. 48 # Config used only by ICU code.
39 config("icu_code") { 49 config("icu_code") {
40 cflags = [] 50 cflags = []
41 defines = [ 51 defines = [
42 "HAVE_DLOPEN=0", 52 "HAVE_DLOPEN=0",
43 53
44 # Only build encoding coverters and detectors necessary for HTML5. 54 # Only build encoding coverters and detectors necessary for HTML5.
45 "UCONFIG_NO_NON_HTML5_CONVERSION=1", 55 "UCONFIG_NO_NON_HTML5_CONVERSION=1",
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 sources = [ 593 sources = [
584 "android/icudtl_dat.S", 594 "android/icudtl_dat.S",
585 ] 595 ]
586 } else { 596 } else {
587 assert(false, "No icu data for this platform") 597 assert(false, "No icu data for this platform")
588 } 598 }
589 defines = [ "U_HIDE_DATA_SYMBOL" ] 599 defines = [ "U_HIDE_DATA_SYMBOL" ]
590 } 600 }
591 } 601 }
592 } 602 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698