BUILD.gn - Issue 1991833002: Fix use_icu_data_file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1991833002: Fix use_icu_data_file. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 7dacd6b7fa23c16bbf0342d335135a4cafac2b46..42b7130a6bcf5281054d4d64ab3dc3ac7fd681d2 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -33,6 +33,16 @@ config("icu_config") {

"source/common",

"source/i18n",

]

+ if (icu_use_data_file) {

+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]

+ } else {

+ if (is_win) {

+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]

+ } else {

+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]

+ }

jungshik at Google 2016/05/18 21:11:13 didn't realize that BUILD.gn does not have these d

}

# Config used only by ICU code.

« no previous file with comments | « no previous file | no next file » | no next file with comments »