Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: extensions/browser/api/alarms/alarms_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/alarms/alarms_api.cc
diff --git a/extensions/browser/api/alarms/alarms_api.cc b/extensions/browser/api/alarms/alarms_api.cc
index fa27a54d0c4b4d16d1a67abea4452aaeb8b3c563..c6911330d2d53eee427c1c5b79ce2d320b0a5fca 100644
--- a/extensions/browser/api/alarms/alarms_api.cc
+++ b/extensions/browser/api/alarms/alarms_api.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
+#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/time/clock.h"
#include "base/time/default_clock.h"
@@ -186,7 +187,7 @@ bool AlarmsClearFunction::RunAsync() {
}
void AlarmsClearFunction::Callback(const std::string& name, bool success) {
- SetResult(new base::FundamentalValue(success));
+ SetResult(base::MakeUnique<base::FundamentalValue>(success));
SendResponse(true);
}
@@ -198,7 +199,7 @@ bool AlarmsClearAllFunction::RunAsync() {
}
void AlarmsClearAllFunction::Callback() {
- SetResult(new base::FundamentalValue(true));
+ SetResult(base::MakeUnique<base::FundamentalValue>(true));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698