Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: extensions/browser/api/alarms/alarms_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/alarms/alarms_api.h" 5 #include "extensions/browser/api/alarms/alarms_api.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/memory/ptr_util.h"
9 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
10 #include "base/time/clock.h" 11 #include "base/time/clock.h"
11 #include "base/time/default_clock.h" 12 #include "base/time/default_clock.h"
12 #include "base/values.h" 13 #include "base/values.h"
13 #include "extensions/browser/api/alarms/alarm_manager.h" 14 #include "extensions/browser/api/alarms/alarm_manager.h"
14 #include "extensions/common/api/alarms.h" 15 #include "extensions/common/api/alarms.h"
15 #include "extensions/common/error_utils.h" 16 #include "extensions/common/error_utils.h"
16 17
17 namespace extensions { 18 namespace extensions {
18 19
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 180
180 std::string name = params->name.get() ? *params->name : kDefaultAlarmName; 181 std::string name = params->name.get() ? *params->name : kDefaultAlarmName;
181 AlarmManager::Get(browser_context()) 182 AlarmManager::Get(browser_context())
182 ->RemoveAlarm(extension_id(), name, 183 ->RemoveAlarm(extension_id(), name,
183 base::Bind(&AlarmsClearFunction::Callback, this, name)); 184 base::Bind(&AlarmsClearFunction::Callback, this, name));
184 185
185 return true; 186 return true;
186 } 187 }
187 188
188 void AlarmsClearFunction::Callback(const std::string& name, bool success) { 189 void AlarmsClearFunction::Callback(const std::string& name, bool success) {
189 SetResult(new base::FundamentalValue(success)); 190 SetResult(base::MakeUnique<base::FundamentalValue>(success));
190 SendResponse(true); 191 SendResponse(true);
191 } 192 }
192 193
193 bool AlarmsClearAllFunction::RunAsync() { 194 bool AlarmsClearAllFunction::RunAsync() {
194 AlarmManager::Get(browser_context()) 195 AlarmManager::Get(browser_context())
195 ->RemoveAllAlarms(extension_id(), 196 ->RemoveAllAlarms(extension_id(),
196 base::Bind(&AlarmsClearAllFunction::Callback, this)); 197 base::Bind(&AlarmsClearAllFunction::Callback, this));
197 return true; 198 return true;
198 } 199 }
199 200
200 void AlarmsClearAllFunction::Callback() { 201 void AlarmsClearAllFunction::Callback() {
201 SetResult(new base::FundamentalValue(true)); 202 SetResult(base::MakeUnique<base::FundamentalValue>(true));
202 SendResponse(true); 203 SendResponse(true);
203 } 204 }
204 205
205 } // namespace extensions 206 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698