Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3181)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 3427d2a935de1ac81f00a2797377861fddeff346..f8a538fd9e6720ea9ca3494ad9b04d1455c99dfe 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <memory>
+
#include "base/logging.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
@@ -62,7 +64,7 @@ class PanelExtensionWindowController : public extensions::WindowController {
// Overridden from extensions::WindowController.
int GetWindowId() const override;
std::string GetWindowTypeText() const override;
- base::DictionaryValue* CreateWindowValueWithTabs(
+ std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(
const extensions::Extension* extension) const override;
base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,
int tab_index) const override;
@@ -99,10 +101,10 @@ std::string PanelExtensionWindowController::GetWindowTypeText() const {
return extensions::tabs_constants::kWindowTypeValuePanel;
}
-base::DictionaryValue*
+std::unique_ptr<base::DictionaryValue>
PanelExtensionWindowController::CreateWindowValueWithTabs(
const extensions::Extension* extension) const {
- base::DictionaryValue* result = CreateWindowValue();
+ std::unique_ptr<base::DictionaryValue> result = CreateWindowValue();
base::DictionaryValue* tab_value = CreateTabValue(extension, 0);
if (tab_value) {

Powered by Google App Engine
This is Rietveld 408576698