Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6506)

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/extension_api/tts_extension_api.cc
diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc
index be3eabfddd723e17a7095d475fe3f235c366b8ce..e8b3b18c917fed788cd3084d49187af0c255b4c8 100644
--- a/chrome/browser/speech/extension_api/tts_extension_api.cc
+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc
@@ -9,6 +9,7 @@
#include <utility>
#include "base/lazy_instance.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/speech/extension_api/tts_engine_extension_api.h"
@@ -308,8 +309,8 @@ bool TtsResumeFunction::RunSync() {
}
bool TtsIsSpeakingFunction::RunSync() {
- SetResult(
- new base::FundamentalValue(TtsController::GetInstance()->IsSpeaking()));
+ SetResult(base::MakeUnique<base::FundamentalValue>(
+ TtsController::GetInstance()->IsSpeaking()));
return true;
}
@@ -343,7 +344,7 @@ bool TtsGetVoicesFunction::RunSync() {
result_voices->Append(result_voice);
}
- SetResult(result_voices.release());
+ SetResult(std::move(result_voices));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698