chrome/browser/extensions/browser_extension_window_controller.h - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.h

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_extension_window_controller.h

diff --git a/chrome/browser/extensions/browser_extension_window_controller.h b/chrome/browser/extensions/browser_extension_window_controller.h

index 0106a77a9d9ca4546a90909123b331e3f24e81bb..29addae0213f2630d473109006482be373db5178 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.h

+++ b/chrome/browser/extensions/browser_extension_window_controller.h

@@ -22,8 +22,7 @@ class BrowserExtensionWindowController : public extensions::WindowController {

// extensions::WindowController implementation.

int GetWindowId() const override;

std::string GetWindowTypeText() const override;

- base::DictionaryValue* CreateWindowValue() const override;

- base::DictionaryValue* CreateWindowValueWithTabs(

+ std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(

const extensions::Extension* extension) const override;

base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,

int tab_index) const override;