Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_extension_window_controller.cc
diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc
index 2b49a19ccd9efb69f1bd2b3de0d3eb52b9c8320b..1ffee7e02e0064b62ec03bc9ec3ac62773a0588f 100644
--- a/chrome/browser/extensions/browser_extension_window_controller.cc
+++ b/chrome/browser/extensions/browser_extension_window_controller.cc
@@ -41,17 +41,10 @@ std::string BrowserExtensionWindowController::GetWindowTypeText() const {
return keys::kWindowTypeValueNormal;
}
-base::DictionaryValue*
-BrowserExtensionWindowController::CreateWindowValue() const {
- base::DictionaryValue* result =
- extensions::WindowController::CreateWindowValue();
- return result;
-}
-
-base::DictionaryValue*
+std::unique_ptr<base::DictionaryValue>
BrowserExtensionWindowController::CreateWindowValueWithTabs(
const extensions::Extension* extension) const {
- base::DictionaryValue* result = CreateWindowValue();
+ std::unique_ptr<base::DictionaryValue> result = CreateWindowValue();
result->Set(keys::kTabsKey,
extensions::ExtensionTabUtil::CreateTabList(browser_, extension));

Powered by Google App Engine
This is Rietveld 408576698