chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/api/top_sites/top_sites_api.cc ('k') | chrome/browser/extensions/browser_extension_window_controller.h » ('j') | chrome/browser/extensions/extension_tab_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

index bd0d7f37f588bc130e09000f231415f3983fb36d..3c939662cb2b10c53a31cf267f8523dbe5ba1413 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

@@ -128,7 +128,7 @@ void WebrtcLoggingPrivateFunctionWithUploadCallback::FireCallback(

if (success) {

api::webrtc_logging_private::UploadResult result;

result.report_id = report_id;

- SetResult(result.ToValue().release());

+ SetResult(result.ToValue());

} else {

SetError(error_message);

}

@@ -151,7 +151,7 @@ void WebrtcLoggingPrivateFunctionWithRecordingDoneCallback::FireCallback(

result.prefix_path = prefix_path;

result.did_stop = did_stop;

result.did_manual_stop = did_manual_stop;

- SetResult(result.ToValue().release());

+ SetResult(result.ToValue());

SendResponse(true);

}