Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_tab_util.h

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/browser_extension_window_controller.cc ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | chrome/browser/extensions/extension_tab_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util.h
diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h
index 7ec1adef4d7dc59c71042c4af27c44f4f2a0fc51..7b34826eefe08039a2117e8cac986ecd668e2ed1 100644
--- a/chrome/browser/extensions/extension_tab_util.h
+++ b/chrome/browser/extensions/extension_tab_util.h
@@ -68,8 +68,9 @@ class ExtensionTabUtil {
static int GetTabId(const content::WebContents* web_contents);
static std::string GetTabStatusText(bool is_loading);
static int GetWindowIdOfTab(const content::WebContents* web_contents);
- static base::ListValue* CreateTabList(const Browser* browser,
- const Extension* extension);
+ static std::unique_ptr<base::ListValue> CreateTabList(
+ const Browser* browser,
+ const Extension* extension);
// DEPRECATED: Please consider using ChromeExtensionFunctionDetails instead
// of the deprecated ChromeUIThreadExtensionFunction and use the overload
« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/browser_extension_window_controller.cc ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | chrome/browser/extensions/extension_tab_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698