chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/api/module/module.cc ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | chrome/browser/extensions/extension_tab_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc b/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

index b51ec55d2ff3a21762522d802c9d20537784e81e..cb0f24b541c2f46e5265c792c826b67f5e778f3d 100644

--- a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

+++ b/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h"

+#include "base/memory/ptr_util.h"

#include "chrome/browser/extensions/api/music_manager_private/device_id.h"

using content::BrowserThread;

@@ -44,7 +45,7 @@ void MusicManagerPrivateGetDeviceIdFunction::DeviceIdCallback(

SetError(kDeviceIdNotSupported);

response = false;

} else {

- SetResult(new base::StringValue(device_id));

+ SetResult(base::MakeUnique<base::StringValue>(device_id));

response = true;

}