Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4584)

Unified Diff: chrome/browser/extensions/api/module/module.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/module/module.cc
diff --git a/chrome/browser/extensions/api/module/module.cc b/chrome/browser/extensions/api/module/module.cc
index 13bc0f0df12d6744a4753d76d29fe07e82572a9e..7bd4f26599a266f898690acd7780199d77206ca7 100644
--- a/chrome/browser/extensions/api/module/module.cc
+++ b/chrome/browser/extensions/api/module/module.cc
@@ -6,6 +6,7 @@
#include <string>
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
@@ -50,13 +51,13 @@ bool ExtensionSetUpdateUrlDataFunction::RunSync() {
}
bool ExtensionIsAllowedIncognitoAccessFunction::RunSync() {
- SetResult(new base::FundamentalValue(
+ SetResult(base::MakeUnique<base::FundamentalValue>(
util::IsIncognitoEnabled(extension_id(), GetProfile())));
return true;
}
bool ExtensionIsAllowedFileSchemeAccessFunction::RunSync() {
- SetResult(new base::FundamentalValue(
+ SetResult(base::MakeUnique<base::FundamentalValue>(
util::AllowFileAccess(extension_id(), GetProfile())));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698