Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/music_manager_private/music_manager_priv ate_api.h" 5 #include "chrome/browser/extensions/api/music_manager_private/music_manager_priv ate_api.h"
6 6
7 #include "base/memory/ptr_util.h"
7 #include "chrome/browser/extensions/api/music_manager_private/device_id.h" 8 #include "chrome/browser/extensions/api/music_manager_private/device_id.h"
8 9
9 using content::BrowserThread; 10 using content::BrowserThread;
10 11
11 namespace { 12 namespace {
12 13
13 const char kDeviceIdNotSupported[] = 14 const char kDeviceIdNotSupported[] =
14 "Device ID API is not supported on this platform."; 15 "Device ID API is not supported on this platform.";
15 16
16 } 17 }
(...skipping 20 matching lines...) Expand all
37 } 38 }
38 39
39 void MusicManagerPrivateGetDeviceIdFunction::DeviceIdCallback( 40 void MusicManagerPrivateGetDeviceIdFunction::DeviceIdCallback(
40 const std::string& device_id) { 41 const std::string& device_id) {
41 DCHECK_CURRENTLY_ON(BrowserThread::UI); 42 DCHECK_CURRENTLY_ON(BrowserThread::UI);
42 bool response; 43 bool response;
43 if (device_id.empty()) { 44 if (device_id.empty()) {
44 SetError(kDeviceIdNotSupported); 45 SetError(kDeviceIdNotSupported);
45 response = false; 46 response = false;
46 } else { 47 } else {
47 SetResult(new base::StringValue(device_id)); 48 SetResult(base::MakeUnique<base::StringValue>(device_id));
48 response = true; 49 response = true;
49 } 50 }
50 51
51 SendResponse(response); 52 SendResponse(response);
52 } 53 }
53 54
54 } // namespace api 55 } // namespace api
55 } // namespace extensions 56 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698