Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1990783002: Mac: Open chrome://apps when a deprecated app launcher shim connects. (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160518-ShimAppsPage-UPSTREAM
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Open chrome://apps when a deprecated app launcher shim connects. The App Launcher UI is being deleted from Chrome on Mac, but the shim/shortcuts still exist on users computers. Have them open a browser tab at chrome://apps. BUG=600915 Committed: https://crrev.com/5da636ae5bd522e23fcac934adaea13017c1199f Cr-Commit-Position: refs/heads/master@{#394370}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : git rebase as well? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -15 lines) Patch
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 5 chunks +31 lines, -15 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_service_disabled_mac.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_service_disabled_mac.mm View 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
tapted
Hi Chris, please take a look
4 years, 7 months ago (2016-05-18 03:46:34 UTC) #2
tapted
PTAL - rebased. tryjobs here are with enable_app_list=1, try jobs in http://crrev.com/1934213002/ will have enable_app_list=0
4 years, 7 months ago (2016-05-18 07:10:01 UTC) #4
calamity
lgtm
4 years, 7 months ago (2016-05-18 07:35:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990783002/60001
4 years, 7 months ago (2016-05-18 08:45:23 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 09:28:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 09:30:48 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5da636ae5bd522e23fcac934adaea13017c1199f
Cr-Commit-Position: refs/heads/master@{#394370}

Powered by Google App Engine
This is Rietveld 408576698