Make --show-app-list go to the chrome://apps page.

Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891
Committed: https://crrev.com/f95f7d827a6b42842321e70c9cd2cc513ccdae5c
Cr-Commit-Position: refs/heads/master@{#394349}

[calamity, 2016-05-13 04:10:47]

Patchset #1 (id:1) has been deleted

[calamity, 2016-05-13 04:13:10]

Description was changed from

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher.

BUG=
==========

to

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891
==========

[calamity, 2016-05-16 06:29:43]

Patchset #3 (id:60001) has been deleted

[calamity, 2016-05-16 06:29:50]

Patchset #3 (id:80001) has been deleted

[calamity, 2016-05-17 02:03:11]

Patchset #3 (id:100001) has been deleted

[calamity, 2016-05-17 02:03:21]

Patchset #2 (id:40001) has been deleted

[calamity, 2016-05-17 02:03:31]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-05-17 02:03:40]

calamity@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2016-05-17 03:11:13]

https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_service.cc:53: chrome::NavigateParams
params(browser ? browser->profile() : launch_profile,
app_list_service.cc isn't compiled when enable_app_list=0

this needs to go in app_list_service_disabled.cc

and I think this part of the diff is the only change you'll need.

[tapted, 2016-05-17 03:27:11]

On 2016/05/17 03:11:13, tapted wrote:
>
https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
> File chrome/browser/ui/app_list/app_list_service.cc (right):
> 
>
https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
> chrome/browser/ui/app_list/app_list_service.cc:53: chrome::NavigateParams
> params(browser ? browser->profile() : launch_profile,
> app_list_service.cc isn't compiled when enable_app_list=0
> 
> this needs to go in app_list_service_disabled.cc
> 
> and I think this part of the diff is the only change you'll need.

btw - you can try basing off http://crrev.com/1934213002 if you want to run a
change through the CQ

[calamity, 2016-05-18 01:11:38]

https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_service.cc (right):

https://codereview.chromium.org/1973203002/diff/120001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_service.cc:53: chrome::NavigateParams
params(browser ? browser->profile() : launch_profile,
On 2016/05/17 03:11:13, tapted wrote:
> app_list_service.cc isn't compiled when enable_app_list=0
> 
> this needs to go in app_list_service_disabled.cc
> 
> and I think this part of the diff is the only change you'll need.

Done.

[tapted, 2016-05-18 01:38:25]

lgtm - assuming you tested both chrome-running and chrome-not-running :)

you'll need to clobber the patchset dependency. I've rebased
https://codereview.chromium.org/1934213002 and I'm running some jobs there with
this CL patched in as a dependency instead.

[tapted, 2016-05-18 03:17:04]

https://codereview.chromium.org/1973203002/diff/140001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_service_disabled.cc (right):

https://codereview.chromium.org/1973203002/diff/140001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_service_disabled.cc:14: #include
"ui/base/page_transition_types.h"
looks like you also need

#include "base/command_line.h"
#include "chrome/common/url_constants.h"

[tapted, 2016-05-18 03:44:30]

also BUG= should be 600915 (576891 is a dupe)

[tapted, 2016-05-18 03:58:27]

https://codereview.chromium.org/1973203002/diff/140001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_service_disabled.cc (right):

https://codereview.chromium.org/1973203002/diff/140001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_service_disabled.cc:9: #include
"chrome/browser/ui/browser.h"
bleh all this should be #if defined(TOOLKIT_VIEWS) too -  I think that's the
most robust way. Currently android gets

../../chrome/browser/ui/app_list/app_list_service_disabled.cc:27:error:
undefined reference to 'chrome::FindLastActive()'
../../chrome/browser/ui/app_list/app_list_service_disabled.cc:32:error:
undefined reference to 'chrome::Navigate(chrome::NavigateParams*)'

[tapted, 2016-05-18 05:49:11]

lgtm

[calamity, 2016-05-18 06:36:53]

Patchset #5 (id:200001) has been deleted

[calamity, 2016-05-18 06:37:02]

Patchset #5 (id:220001) has been deleted

[calamity, 2016-05-18 07:10:18]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-05-18 07:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1973203002/#ps260001
(title: "remove dep patchset")

[commit-bot: I haz the power, 2016-05-18 07:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973203002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973203002/260001

[commit-bot: I haz the power, 2016-05-18 07:27:37]

Description was changed from

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891
==========

to

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891
==========

[commit-bot: I haz the power, 2016-05-18 07:27:38]

Committed patchset #6 (id:260001)

[commit-bot: I haz the power, 2016-05-18 07:29:32]

Description was changed from

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891
==========

to

==========
Make --show-app-list go to the chrome://apps page.

This CL makes app launcher shortcuts launch the chrome://apps page rather
than the actual app launcher. The profile of the last active profile
will be used or the last launched profile otherwise.

BUG=576891

Committed: https://crrev.com/f95f7d827a6b42842321e70c9cd2cc513ccdae5c
Cr-Commit-Position: refs/heads/master@{#394349}
==========

[commit-bot: I haz the power, 2016-05-18 07:29:34]

Patchset 6 (id:??) landed as
https://crrev.com/f95f7d827a6b42842321e70c9cd2cc513ccdae5c
Cr-Commit-Position: refs/heads/master@{#394349}