Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 1934213002: Set enable_app_list=1 now only on ChromeOS. (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, sky, hans
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160429-AppList0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set enable_app_list=1 now only on ChromeOS. Turn down app_list_unittests on Mac. Moves app_list_unittests and app_list_presenter_unittests to the same place as ash_unittests on other non-ChromeOS bots. BUG=600915 Committed: https://crrev.com/87ca2d6836730fb7cacf7c76e33e100df599b754 Cr-Commit-Position: refs/heads/master@{#394856}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : now just one depends patchset #

Patch Set 4 : app_list_unittests whackamole #

Patch Set 5 : fix ash_test_resources #

Total comments: 2

Patch Set 6 : keep app_list_unittests on aura #

Patch Set 7 : Update ui_test_pak - should fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -99 lines) Patch
M BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -12 lines 0 comments Download
M ash/ash_resources.gyp View 1 2 3 4 2 chunks +2 lines, -10 lines 0 comments Download
M ash/resources/BUILD.gn View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download
M build/all.gyp View 1 2 3 4 5 5 chunks +4 lines, -20 lines 0 comments Download
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/features.gni View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 5 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 2 3 6 chunks +0 lines, -36 lines 0 comments Download
M ui/resources/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/ui_resources.gyp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
tapted
Hi Dirk and sky, please take a look Dirk mainly for src/build sky for the ...
4 years, 7 months ago (2016-05-18 12:45:24 UTC) #9
Dirk Pranke
lgtm. https://codereview.chromium.org/1934213002/diff/200001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/1934213002/diff/200001/testing/buildbot/chromium_trybot.json#newcode23 testing/buildbot/chromium_trybot.json:23: ], I'm guessing you added these lines because ...
4 years, 7 months ago (2016-05-18 15:49:21 UTC) #10
sky
On 2016/05/18 12:45:24, tapted wrote: > Hi Dirk and sky, please take a look > ...
4 years, 7 months ago (2016-05-18 16:44:56 UTC) #11
tapted
On 2016/05/18 16:44:56, sky wrote: > > The bit I'm *not* so sure about it ...
4 years, 7 months ago (2016-05-18 22:01:37 UTC) #14
tapted
sky, PTAL On 2016/05/18 22:01:37, tapted wrote: > I've tweaked the CL to keep app_list_unittests ...
4 years, 7 months ago (2016-05-19 11:49:12 UTC) #15
sky
LGTM
4 years, 7 months ago (2016-05-19 16:34:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1934213002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1934213002/260001
4 years, 7 months ago (2016-05-19 20:43:02 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:260001)
4 years, 7 months ago (2016-05-19 20:49:05 UTC) #21
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/87ca2d6836730fb7cacf7c76e33e100df599b754 Cr-Commit-Position: refs/heads/master@{#394856}
4 years, 7 months ago (2016-05-19 20:50:21 UTC) #23
hans
This broke "isolate_tests" on e.g. this bot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/5287/steps/isolate%20tests/logs/stdio It seems app_list_presenter_unittests_run is no longer built ...
4 years, 7 months ago (2016-05-20 17:10:35 UTC) #25
hans
4 years, 7 months ago (2016-05-20 17:12:59 UTC) #26
Message was sent while issue was closed.
On 2016/05/20 17:10:35, hans wrote:
> This broke "isolate_tests" on e.g. this bot:
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/5287/...
> 
> It seems app_list_presenter_unittests_run is no longer built as part of "all".
> 
> One way to reproduce (on Linux):
> 
> $ GYP_DEFINES='test_isolation_mode=prepare' build/gyp_chromium
> $ ninja -C out/Release -n | grep app_list_presenter_unittests_run
> (crickets)
> 
> 
> I'm not exactly what part of this change made it break though.

D'oh, now I see! It's the condition in gn_migration.gypi that needs updating:
https://code.google.com/p/chromium/codesearch#chromium/src/build/gn_migration...

I'll prepare a patch.

Powered by Google App Engine
This is Rietveld 408576698