Add a compile time flag to only upload crash symbols for official builds

Add a compile time flag to only upload crash symbols for official builds

BUG=597454
Committed: https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552
Cr-Commit-Position: refs/heads/master@{#394486}

[marcinjb, 2016-05-18 01:43:33]

marcinjb@chromium.org changed reviewers:
+ kmarshall@chromium.org

[marcinjb, 2016-05-18 01:43:34]

I did this as a compiler flag since we hide the generation of the breakpad
symbol file behind one as well.

After this is submitted, engines run (and crashed) by developers won't show up
in our crash metrics.  w00t

[Kevin M, 2016-05-18 16:46:42]

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:52: defines = []
Why are we zapping the defines? Wouldn't this throw away beneficial defines like
NDEBUG, OS_XYZ, etc.?

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:54: defines += [ "OFFICIAL_BLIMP_BUILD" ]
Dumb question, but why can't we use the OFFICIAL_BUILD define instead?

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_reporter_client.cc (right):

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:48: // Always collect
Blimp engine crash reports on official builds
Add a trailing dot.

[marcinjb, 2016-05-18 17:39:24]

PTAL

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:52: defines = []
On 2016/05/18 16:46:42, Kevin M wrote:
> Why are we zapping the defines? Wouldn't this throw away beneficial defines
like
> NDEBUG, OS_XYZ, etc.?

Obsolete, however if I didn't have this here, I'd get yelled at with about the
line below saying "can't append to something that isn't there."  Weird...

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:54: defines += [ "OFFICIAL_BLIMP_BUILD" ]
On 2016/05/18 16:46:42, Kevin M wrote:
> Dumb question, but why can't we use the OFFICIAL_BUILD define instead?

Because I was dumb and missed OFFICIAL_BUILD in features.gni.

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/app/blimp_...
File blimp/engine/app/blimp_engine_crash_reporter_client.cc (right):

https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/app/blimp_...
blimp/engine/app/blimp_engine_crash_reporter_client.cc:48: // Always collect
Blimp engine crash reports on official builds
On 2016/05/18 16:46:42, Kevin M wrote:
> Add a trailing dot.

Done.

[Kevin M, 2016-05-18 18:00:00]

lgtm

[marcinjb, 2016-05-18 18:15:18]

The CQ bit was checked by marcinjb@chromium.org

[commit-bot: I haz the power, 2016-05-18 18:16:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990723002/40001

[commit-bot: I haz the power, 2016-05-18 18:58:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 18:59:49]

Description was changed from

==========
Add a compile time flag to only upload crash symbols for official builds

BUG=597454
==========

to

==========
Add a compile time flag to only upload crash symbols for official builds

BUG=597454

Committed: https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552
Cr-Commit-Position: refs/heads/master@{#394486}
==========

[commit-bot: I haz the power, 2016-05-18 18:59:50]

Patchset 3 (id:??) landed as
https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552
Cr-Commit-Position: refs/heads/master@{#394486}