Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1990723002: Add a compile time flag to only upload crash symbols for official builds (Closed)

Created:
4 years, 7 months ago by marcinjb
Modified:
4 years, 7 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a compile time flag to only upload crash symbols for official builds BUG=597454 Committed: https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552 Cr-Commit-Position: refs/heads/master@{#394486}

Patch Set 1 #

Patch Set 2 : ::shamecube:: Remove silly debug file #

Total comments: 6

Patch Set 3 : Address kmarshall's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M blimp/engine/app/blimp_engine_crash_reporter_client.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
marcinjb
I did this as a compiler flag since we hide the generation of the breakpad ...
4 years, 7 months ago (2016-05-18 01:43:34 UTC) #2
Kevin M
https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn File blimp/engine/BUILD.gn (right): https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#newcode52 blimp/engine/BUILD.gn:52: defines = [] Why are we zapping the defines? ...
4 years, 7 months ago (2016-05-18 16:46:42 UTC) #3
marcinjb
PTAL https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn File blimp/engine/BUILD.gn (right): https://codereview.chromium.org/1990723002/diff/20001/blimp/engine/BUILD.gn#newcode52 blimp/engine/BUILD.gn:52: defines = [] On 2016/05/18 16:46:42, Kevin M ...
4 years, 7 months ago (2016-05-18 17:39:24 UTC) #4
Kevin M
lgtm
4 years, 7 months ago (2016-05-18 18:00:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990723002/40001
4 years, 7 months ago (2016-05-18 18:16:01 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 18:58:46 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:59:50 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552
Cr-Commit-Position: refs/heads/master@{#394486}

Powered by Google App Engine
This is Rietveld 408576698