Add a compile time flag to only upload crash symbols for official builds

blimp/engine/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//tools/grit/repack.gni")
@@ skipping 28 matching lines @@
 
   if (toolkit_views) {
     deps += [ "//ui/views/resources" ]
     sources +=
         [ "$root_gen_dir/ui/views/resources/views_resources_100_percent.pak" ]
   }
 
   output = "$root_out_dir/blimp_engine.pak"
 }
 
+# Config for defining compile-time official build flags.
+config("official_build_config") {
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  defines = []

[Kevin M, 2016/05/18 16:46:42]

Why are we zapping the defines? Wouldn't this throw away beneficial defines like
NDEBUG, OS_XYZ, etc.?

[marcinjb, 2016/05/18 17:39:24]

Obsolete, however if I didn't have this here, I'd get yelled at with about the
line below saying "can't append to something that isn't there."  Weird...

+  if (is_official_build) {
+    defines += [ "OFFICIAL_BLIMP_BUILD" ]

[Kevin M, 2016/05/18 16:46:42]

Dumb question, but why can't we use the OFFICIAL_BUILD define instead?

[marcinjb, 2016/05/18 17:39:24]

Because I was dumb and missed OFFICIAL_BUILD in features.gni.

+  }
+}
+
 source_set("app") {
   sources = [
     "app/blimp_browser_main_parts.cc",
     "app/blimp_browser_main_parts.h",
     "app/blimp_content_browser_client.cc",
     "app/blimp_content_browser_client.h",
     "app/blimp_content_main_delegate.cc",
     "app/blimp_content_main_delegate.h",
   ]
 
@@ skipping 152 matching lines @@
 
   deps = [
     "//base",
     "//components/crash/content/app:app_breakpad_mac_win_to_be_deleted",
     "//components/crash/content/app:lib",
     "//components/crash/core/common",
     "//components/version_info",
     "//components/version_info:generate_version_info",
     "//content/public/common",
   ]
+
+  configs += [ ":official_build_config" ]
 }
 
 source_set("common") {
   sources = [
     "common/blimp_browser_context.cc",
     "common/blimp_browser_context.h",
     "common/blimp_content_client.cc",
     "common/blimp_content_client.h",
   ]
 
@@ skipping 330 matching lines @@
         rebase_path(symbol_file, root_build_dir),
       ]
 
       deps = [
         ":blimp_engine_app",
         dump_syms_label,
       ]
     }
   }
 }