Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: blimp/engine/app/blimp_engine_crash_reporter_client.cc

Issue 1990723002: Add a compile time flag to only upload crash symbols for official builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address kmarshall's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_engine_crash_reporter_client.h" 5 #include "blimp/engine/app/blimp_engine_crash_reporter_client.h"
6 6
7 #include "blimp/engine/app/blimp_engine_crash_keys.h" 7 #include "blimp/engine/app/blimp_engine_crash_keys.h"
8 #include "components/crash/core/common/crash_keys.h" 8 #include "components/crash/core/common/crash_keys.h"
9 #include "components/version_info/version_info_values.h" 9 #include "components/version_info/version_info_values.h"
10 #include "content/public/common/content_switches.h" 10 #include "content/public/common/content_switches.h"
(...skipping 27 matching lines...) Expand all
38 38
39 bool BlimpEngineCrashReporterClient::IsRunningUnattended() { 39 bool BlimpEngineCrashReporterClient::IsRunningUnattended() {
40 // If this returns "true," crash reports will not be uploaded. For now the 40 // If this returns "true," crash reports will not be uploaded. For now the
41 // engine will not be running unattended. Eventually when automated testing 41 // engine will not be running unattended. Eventually when automated testing
42 // harnesses are set up, this should be changed to return "true" in those 42 // harnesses are set up, this should be changed to return "true" in those
43 // cases. 43 // cases.
44 return false; 44 return false;
45 } 45 }
46 46
47 bool BlimpEngineCrashReporterClient::GetCollectStatsConsent() { 47 bool BlimpEngineCrashReporterClient::GetCollectStatsConsent() {
48 // Always collect Blimp engine crash reports. 48 // Always collect Blimp engine crash reports on official builds.
49 #ifdef OFFICIAL_BUILD
49 return true; 50 return true;
51 #else
52 return false;
53 #endif // OFFICIAL_BUILD
50 } 54 }
51 55
52 bool BlimpEngineCrashReporterClient::EnableBreakpadForProcess( 56 bool BlimpEngineCrashReporterClient::EnableBreakpadForProcess(
53 const std::string& process_type) { 57 const std::string& process_type) {
54 return process_type == ::switches::kRendererProcess || 58 return process_type == ::switches::kRendererProcess ||
55 process_type == ::switches::kPpapiPluginProcess || 59 process_type == ::switches::kPpapiPluginProcess ||
56 process_type == ::switches::kZygoteProcess || 60 process_type == ::switches::kZygoteProcess ||
57 process_type == ::switches::kGpuProcess; 61 process_type == ::switches::kGpuProcess;
58 } 62 }
59 63
60 } // namespace engine 64 } // namespace engine
61 } // namespace blimp 65 } // namespace blimp
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698