third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 1990353002: [DevTools] Capture call stacks for console messages without location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 1990353002: [DevTools] Capture call stacks for console messages without location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more win7 expectation Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessage.h ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

index 40f2ae248586104654daf7ed98e62aeeef48402d..360661ecddf63a1618bd81d21fa3f96eeb96d2a8 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

@@ -40,7 +40,7 @@ public:

bool isExecutionAllowed() override;

double currentTimeMS() override;

bool isInspectableHeapObject(v8::Local<v8::Object>) override;

- void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount, int maxStackSize) final;

+ void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) final;

void consoleTime(const String16& title) override;

void consoleTimeEnd(const String16& title) override;

void consoleTimeStamp(const String16& title) override;