Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.h

Issue 1990353002: [DevTools] Capture call stacks for console messages without location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more win7 expectation Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.h
diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
index a1211ba3020cde4b3058be4eab9ea4ba8ff58350..9458883cef668a3c9fce167beba857e0eef2dab9 100644
--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
@@ -24,10 +24,18 @@ class WorkerInspectorProxy;
class CORE_EXPORT ConsoleMessage final: public GarbageCollectedFinalized<ConsoleMessage> {
public:
- static ConsoleMessage* create(MessageSource source, MessageLevel level, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0)
+ static ConsoleMessage* create(MessageSource source, MessageLevel level, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber = 0)
{
return new ConsoleMessage(source, level, message, url, lineNumber, columnNumber);
}
+
+ static ConsoleMessage* create(MessageSource source, MessageLevel level, const String& message)
+ {
+ ConsoleMessage* consoleMessage = new ConsoleMessage(source, level, message, String(), 0, 0);
+ consoleMessage->collectCallStack();
+ return consoleMessage;
+ }
+
~ConsoleMessage();
MessageType type() const;
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameConsole.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698