third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp - Issue 1990353002: [DevTools] Capture call stacks for console messages without location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1990353002: [DevTools] Capture call stacks for console messages without location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more win7 expectation Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ThreadDebugger.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

index 41f05e6cde57af0e512fd4edad96a1c8e04ac20f..6e8d06fd799194b31fe90c23cb3e2487e8e493b8 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

@@ -117,7 +117,7 @@ bool ThreadDebugger::isInspectableHeapObject(v8::Local<v8::Object> object)

return true;

}

-void ThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, MessageType type, MessageLevel level, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount, int maxStackSize)

+void ThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, MessageType type, MessageLevel level, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount)

{

ScriptState* scriptState = ScriptState::from(context);

ScriptArguments* scriptArguments = nullptr;

@@ -132,10 +132,6 @@ void ThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context, Mess

consoleMessage->setScriptState(scriptState);

if (arguments)

consoleMessage->setScriptArguments(scriptArguments);

- if (maxStackSize == -1)

- consoleMessage->setCallStack(ScriptCallStack::captureForConsole());

- else if (maxStackSize)

- consoleMessage->setCallStack(ScriptCallStack::capture(maxStackSize));

reportMessageToConsole(context, consoleMessage);

}