third_party/WebKit/Source/core/frame/FrameConsole.cpp - Issue 1990353002: [DevTools] Capture call stacks for console messages without location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 1990353002: [DevTools] Capture call stacks for console messages without location. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more win7 expectation Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/stereopannernode-panning-expected.txt ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameConsole.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameConsole.cpp b/third_party/WebKit/Source/core/frame/FrameConsole.cpp

index 58c9ae7de278fdfbd93a91658c5c33eb770b40df..a771d907846282c8f115bf4dd47d14c0f706a57f 100644

--- a/third_party/WebKit/Source/core/frame/FrameConsole.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameConsole.cpp

@@ -125,7 +125,7 @@ void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsign

if (response.wasFallbackRequiredByServiceWorker())

return;

String message = "Failed to load resource: the server responded with a status of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusText() + ')';

- ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource, ErrorMessageLevel, message, response.url().getString());

+ ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource, ErrorMessageLevel, message, response.url().getString(), 0);

consoleMessage->setRequestIdentifier(requestIdentifier);

addMessage(consoleMessage);

}

@@ -175,7 +175,7 @@ void FrameConsole::didFailLoading(unsigned long requestIdentifier, const Resourc

message.appendLiteral(": ");

message.append(error.localizedDescription());

}

- ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource, ErrorMessageLevel, message.toString(), error.failingURL());

+ ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource, ErrorMessageLevel, message.toString(), error.failingURL(), 0);

consoleMessage->setRequestIdentifier(requestIdentifier);

storage->reportMessage(m_frame->document(), consoleMessage);

}