Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1988923002: Remove GrRenderTarget from GrPipelineBuilder (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrRenderTarget from GrPipelineBuilder This used to be "Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder" but has been split into: https://codereview.chromium.org/1993263002/ (Make GrAppliedClip friendless) https://codereview.chromium.org/1997773002/ (Retract GrRenderTarget from GLProgramsTest) https://codereview.chromium.org/1993403002/ (GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not GrContext)) https://codereview.chromium.org/2004433002/ (Retract GrRenderTarget from GrTestTarget) https://codereview.chromium.org/2015333002/ (Change parameters to GrPipelineBuilder's ctor) https://codereview.chromium.org/2035823002/ (Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1988923002 Committed: https://skia.googlesource.com/skia/+/55fdcccf01d49173bc731024b4283d3a3ea9150a

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update to ToT #

Patch Set 5 : update #

Patch Set 6 : update to ToT #

Patch Set 7 : update to ToT #

Patch Set 8 : Clean up #

Patch Set 9 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -149 lines) Patch
M gm/beziereffects.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M gm/bigrrectaaeffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/constcolorprocessor.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 6 15 chunks +11 lines, -25 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 5 6 3 chunks +8 lines, -27 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 7 9 chunks +13 lines, -12 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 2 3 4 5 6 3 chunks +1 line, -22 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrStencilAttachment.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 2 3 4 5 6 7 8 4 chunks +1 line, -5 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 2 3 4 5 6 8 chunks +9 lines, -13 lines 0 comments Download
M src/gpu/vk/GrVkStencilAttachment.cpp View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M tools/gpu/GrTest.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
robertphillips
4 years, 6 months ago (2016-06-04 00:27:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988923002/160001
4 years, 6 months ago (2016-06-04 00:50:49 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-04 01:08:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988923002/160001
4 years, 6 months ago (2016-06-06 13:01:40 UTC) #17
bsalomon
lgtm
4 years, 6 months ago (2016-06-06 13:01:43 UTC) #18
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 6 months ago (2016-06-06 13:01:45 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 13:16:24 UTC) #21
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/55fdcccf01d49173bc731024b4283d3a3ea9150a

Powered by Google App Engine
This is Rietveld 408576698