Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1988433002: Replace ThreatEntryType::URL_EXPRESSION with ThreatEntryType::URL (Closed)

Created:
4 years, 7 months ago by vakh (use Gerrit instead)
Modified:
4 years, 7 months ago
CC:
awoz, chromium-reviews, kcarattini, noelutz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ThreatEntryType::URL_EXPRESSION with ThreatEntryType::URL Passes: $ nice ninja -C out/gn_out -j 1000 components_unittests && out/gn_out/components_unittests --gtest_filter="*V4*" BUG=612263, 543161 Committed: https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c Cr-Commit-Position: refs/heads/master@{#395678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M components/safe_browsing_db/safebrowsing.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
vakh (use Gerrit instead)
4 years, 7 months ago (2016-05-16 22:13:33 UTC) #2
vakh (use Gerrit instead)
Ping.
4 years, 7 months ago (2016-05-24 01:31:27 UTC) #4
kcarattini
lgtm
4 years, 7 months ago (2016-05-24 01:38:06 UTC) #6
Nathan Parker
lgtm "URL" is pretty generic... we may run into some namespace collisions later in safe_browsing{}. ...
4 years, 7 months ago (2016-05-24 18:23:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988433002/1
4 years, 7 months ago (2016-05-24 18:38:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 19:52:08 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 19:53:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4976fd011b288796a5c9e0c0ed7ec40a4a4104c
Cr-Commit-Position: refs/heads/master@{#395678}

Powered by Google App Engine
This is Rietveld 408576698