components/safe_browsing_db/v4_get_hash_protocol_manager.cc - Issue 1988433002: Replace ThreatEntryType::URL_EXPRESSION with ThreatEntryType::URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.cc

Issue 1988433002: Replace ThreatEntryType::URL_EXPRESSION with ThreatEntryType::URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/safebrowsing.proto ('k') | components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_get_hash_protocol_manager.cc

diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc

index 139dc3809d3281d7edef218a81c234c160eb5bcd..bb267e984ccb9daaf28df7bd8add5b1ebea0a081 100644

--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc

+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc

@@ -143,7 +143,7 @@ std::string V4GetHashProtocolManager::GetHashRequest(

FindFullHashesRequest req;

ThreatInfo* info = req.mutable_threat_info();

info->add_threat_types(threat_type);

- info->add_threat_entry_types(URL_EXPRESSION);

+ info->add_threat_entry_types(URL);

for (const PlatformType p : platforms) {

info->add_platform_types(p);

}

@@ -192,7 +192,7 @@ bool V4GetHashProtocolManager::ParseHashResponse(

for (const ThreatMatch& match : response.matches()) {

// Make sure the platform and threat entry type match.

if (!(match.has_threat_entry_type() &&

- match.threat_entry_type() == URL_EXPRESSION && match.has_threat())) {

+ match.threat_entry_type() == URL && match.has_threat())) {

RecordParseGetHashResult(UNEXPECTED_THREAT_ENTRY_TYPE_ERROR);

return false;

}