Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 2012553002: s/BINARY_DIGEST/EXECUTABLE in safebrowsing.proto (Closed)

Created:
4 years, 7 months ago by vakh (use Gerrit instead)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, awoz, noƩ
Base URL:
https://chromium.googlesource.com/chromium/src.git@URLEXP2URL
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/BINARY_DIGEST/EXECUTABLE in safebrowsing.proto Also updated the related comment in .proto Passes: $ nice ninja -C out/gn_out -j 1000 components_unittests && out/gn_out/components_unittests --gtest_filter="*V4*" BUG=612263, 543161 Committed: https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c Cr-Commit-Position: refs/heads/master@{#395709}

Patch Set 1 #

Patch Set 2 : git fetch && git pull && gclient sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/safe_browsing_db/safebrowsing.proto View 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
vakh (use Gerrit instead)
4 years, 7 months ago (2016-05-24 19:48:00 UTC) #2
Nathan Parker
lgtm
4 years, 7 months ago (2016-05-24 19:57:32 UTC) #4
vakh (use Gerrit instead)
git fetch && git pull && gclient sync
4 years, 7 months ago (2016-05-24 19:57:56 UTC) #5
Nathan Parker
Oh also: Can you make the subj a bit more descriptive? Maybe add "... in ...
4 years, 7 months ago (2016-05-24 19:58:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012553002/20001
4 years, 7 months ago (2016-05-24 20:00:22 UTC) #10
vakh (use Gerrit instead)
On 2016/05/24 19:58:30, Nathan Parker wrote: > Oh also: Can you make the subj a ...
4 years, 7 months ago (2016-05-24 20:01:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 22:21:40 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9c4485f1ce7cac7ae82f7a4ae36ccc663afe806c Cr-Commit-Position: refs/heads/master@{#395709}
4 years, 7 months ago (2016-05-24 22:23:15 UTC) #15
kcarattini
4 years, 7 months ago (2016-05-25 00:09:14 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698