Add ability to only upload a single Chromium build and check for patch existence

Add ability to only upload a single Chromium build and check for patch existence before applying them.

BUG=skia:5316
Committed: https://skia.googlesource.com/buildbot/+/140f604ea1339a7c8202ff2fce44a23da223a06c

[rmistry, 2016-05-18 12:04:52]

Description was changed from

==========
Add ability to only upload a single Chromium build

BUG=skia:5316
==========

to

==========
Add ability to only upload a single Chromium build and check for patch existence
before applying them.

BUG=skia:5316
==========

[rmistry, 2016-05-18 12:05:01]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[rmistry, 2016-05-18 12:05:09]

rmistry@google.com changed reviewers:
+ benjaminwagner@google.com

[commit-bot: I haz the power, 2016-05-18 12:05:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988073002/1

[commit-bot: I haz the power, 2016-05-18 12:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 12:08:01]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-05-18 14:29:37]

lgtm

A couple questions, but it's probably just that I'm confused.

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
File ct/go/master_scripts/build_chromium/main.go (right):

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
ct/go/master_scripts/build_chromium/main.go:93: if _, _, err :=
util.CreateChromiumBuild("", *targetPlatform, *chromiumHash, *skiaHash,
*applyPatches, false); err != nil {
Seems like this always would want to upload just a single build with patches?

So, would it make sense for CreateChromiumBuild to not build the unpatched
version if both applyPatches and uploadSingleBuild are true?

[rmistry, 2016-05-19 11:21:01]

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
File ct/go/master_scripts/build_chromium/main.go (right):

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
ct/go/master_scripts/build_chromium/main.go:93: if _, _, err :=
util.CreateChromiumBuild("", *targetPlatform, *chromiumHash, *skiaHash,
*applyPatches, false); err != nil {
On 2016/05/18 14:29:37, Ben Wagner wrote:
> Seems like this always would want to upload just a single build with patches?
> 
> So, would it make sense for CreateChromiumBuild to not build the unpatched
> version if both applyPatches and uploadSingleBuild are true?

The (applyPatches && !uploadSingleBuild) was confusing so I now just check for
!uploadSingleBuild. This means that if applyPatches is false and
uploadSingleBuild is false then two patchless builds will be created and
uploaded, we do not have a usecase for this yet but does not hurt to have the
ability to do that.

[rmistry, 2016-05-19 11:57:39]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 11:57:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988073002/20001

[commit-bot: I haz the power, 2016-05-19 12:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 12:04:12]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-05-19 14:09:08]

lgtm

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
File ct/go/master_scripts/build_chromium/main.go (right):

https://codereview.chromium.org/1988073002/diff/1/ct/go/master_scripts/build_...
ct/go/master_scripts/build_chromium/main.go:93: if _, _, err :=
util.CreateChromiumBuild("", *targetPlatform, *chromiumHash, *skiaHash,
*applyPatches, false); err != nil {
On 2016/05/19 11:21:00, rmistry wrote:
> On 2016/05/18 14:29:37, Ben Wagner wrote:
> > Seems like this always would want to upload just a single build with
patches?
> > 
> > So, would it make sense for CreateChromiumBuild to not build the unpatched
> > version if both applyPatches and uploadSingleBuild are true?
> 
> The (applyPatches && !uploadSingleBuild) was confusing so I now just check for
> !uploadSingleBuild. This means that if applyPatches is false and
> uploadSingleBuild is false then two patchless builds will be created and
> uploaded, we do not have a usecase for this yet but does not hurt to have the
> ability to do that.

Oh, I see. I was confused, but the new code is less confusing. :-)

[rmistry, 2016-05-19 14:10:02]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-05-19 14:10:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988073002/20001

[commit-bot: I haz the power, 2016-05-19 14:10:31]

Description was changed from

==========
Add ability to only upload a single Chromium build and check for patch existence
before applying them.

BUG=skia:5316
==========

to

==========
Add ability to only upload a single Chromium build and check for patch existence
before applying them.

BUG=skia:5316

Committed:
https://skia.googlesource.com/buildbot/+/140f604ea1339a7c8202ff2fce44a23da223...
==========

[commit-bot: I haz the power, 2016-05-19 14:10:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/140f604ea1339a7c8202ff2fce44a23da223...