Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: ct/go/master_scripts/build_chromium/main.go

Issue 1988073002: Add ability to only upload a single Chromium build and check for patch existence (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Simplify conditional Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ct/go/master_scripts/run_chromium_perf_on_workers/main.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Application that builds chromium with or without patches and uploads the buil d 1 // Application that builds chromium with or without patches and uploads the buil d
2 // to Google Storage. 2 // to Google Storage.
3 package main 3 package main
4 4
5 import ( 5 import (
6 "flag" 6 "flag"
7 "fmt" 7 "fmt"
8 "time" 8 "time"
9 9
10 "github.com/skia-dev/glog" 10 "github.com/skia-dev/glog"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 if *chromiumHash == "" { 84 if *chromiumHash == "" {
85 glog.Error("Must specify --chromium_hash") 85 glog.Error("Must specify --chromium_hash")
86 return 86 return
87 } 87 }
88 if *skiaHash == "" { 88 if *skiaHash == "" {
89 glog.Error("Must specify --skia_hash") 89 glog.Error("Must specify --skia_hash")
90 return 90 return
91 } 91 }
92 92
93 » if _, _, err := util.CreateChromiumBuild("", *targetPlatform, *chromiumH ash, *skiaHash, *applyPatches); err != nil { 93 » if _, _, err := util.CreateChromiumBuild("", *targetPlatform, *chromiumH ash, *skiaHash, *applyPatches, true); err != nil {
94 glog.Errorf("Error while creating the Chromium build: %s", err) 94 glog.Errorf("Error while creating the Chromium build: %s", err)
95 return 95 return
96 } 96 }
97 97
98 taskCompletedSuccessfully = true 98 taskCompletedSuccessfully = true
99 } 99 }
OLDNEW
« no previous file with comments | « no previous file | ct/go/master_scripts/run_chromium_perf_on_workers/main.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698