Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Application that builds chromium with or without patches and uploads the buil d | 1 // Application that builds chromium with or without patches and uploads the buil d |
| 2 // to Google Storage. | 2 // to Google Storage. |
| 3 package main | 3 package main |
| 4 | 4 |
| 5 import ( | 5 import ( |
| 6 "flag" | 6 "flag" |
| 7 "fmt" | 7 "fmt" |
| 8 "time" | 8 "time" |
| 9 | 9 |
| 10 "github.com/skia-dev/glog" | 10 "github.com/skia-dev/glog" |
| (...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 83 | 83 |
| 84 if *chromiumHash == "" { | 84 if *chromiumHash == "" { |
| 85 glog.Error("Must specify --chromium_hash") | 85 glog.Error("Must specify --chromium_hash") |
| 86 return | 86 return |
| 87 } | 87 } |
| 88 if *skiaHash == "" { | 88 if *skiaHash == "" { |
| 89 glog.Error("Must specify --skia_hash") | 89 glog.Error("Must specify --skia_hash") |
| 90 return | 90 return |
| 91 } | 91 } |
| 92 | 92 |
| 93 » if _, _, err := util.CreateChromiumBuild("", *targetPlatform, *chromiumH ash, *skiaHash, *applyPatches); err != nil { | 93 » if _, _, err := util.CreateChromiumBuild("", *targetPlatform, *chromiumH ash, *skiaHash, *applyPatches, false); err != nil { |
|
dogben
2016/05/18 14:29:37
Seems like this always would want to upload just a
rmistry
2016/05/19 11:21:00
The (applyPatches && !uploadSingleBuild) was confu
dogben
2016/05/19 14:09:08
Oh, I see. I was confused, but the new code is les
| |
| 94 glog.Errorf("Error while creating the Chromium build: %s", err) | 94 glog.Errorf("Error while creating the Chromium build: %s", err) |
| 95 return | 95 return |
| 96 } | 96 } |
| 97 | 97 |
| 98 taskCompletedSuccessfully = true | 98 taskCompletedSuccessfully = true |
| 99 } | 99 } |
| OLD | NEW |