Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1987623002: Reland "Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts" (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

Reland "Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts" Relands https://codereview.chromium.org/1882293003 but with changes that makes it possible for the perf tests to run. BUG=599919 TBR=agrieve@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300623

Patch Set 1 : Pristine revert CL #

Patch Set 2 : Ensured --run-python-script is passed to Android perf tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -649 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 2 chunks +5 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/steps.py View 1 3 chunks +8 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 1 13 chunks +14 lines, -47 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 1 13 chunks +14 lines, -47 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 1 13 chunks +14 lines, -47 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 1 13 chunks +14 lines, -47 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 1 13 chunks +14 lines, -47 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 13 chunks +13 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987623002/20001
4 years, 7 months ago (2016-05-17 10:48:44 UTC) #4
kjellander_chromium
Sorry it took me so long to reland this. The fix was really easy though, ...
4 years, 7 months ago (2016-05-17 10:51:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 10:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987623002/20001
4 years, 7 months ago (2016-05-17 10:54:34 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 10:57:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300623

Powered by Google App Engine
This is Rietveld 408576698