Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 1987623002: Reland "Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Ensured --run-python-script is passed to Android perf tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/webrtc/steps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/webrtc/api.py
diff --git a/scripts/slave/recipe_modules/webrtc/api.py b/scripts/slave/recipe_modules/webrtc/api.py
index 8aa61642bd14e29edd1bdeb9b2a40a5cd03d7762..c9e1abe7e9e4d9e44ab413d7a48e63290ac056c7 100644
--- a/scripts/slave/recipe_modules/webrtc/api.py
+++ b/scripts/slave/recipe_modules/webrtc/api.py
@@ -179,7 +179,8 @@ class WebRTCApi(recipe_api.RecipeApi):
def add_test(self, test, name=None, args=None, revision=None, env=None,
- perf_test=False, perf_dashboard_id=None, parallel=True):
+ python_mode=False, perf_test=False, perf_dashboard_id=None,
+ parallel=True):
"""Helper function to invoke chromium.runtest().
Notice that the name parameter should be the same as the test executable in
@@ -197,11 +198,11 @@ class WebRTCApi(recipe_api.RecipeApi):
test=test, args=args, name=name,
results_url=self.DASHBOARD_UPLOAD_URL, annotate='graphing',
xvfb=True, perf_dashboard_id=perf_dashboard_id,
- test_type=perf_dashboard_id, env=env, revision=self.revision_number,
- perf_id=self.c.PERF_ID, perf_config=self.c.PERF_CONFIG)
+ test_type=perf_dashboard_id, env=env, python_mode=python_mode,
+ revision=self.revision_number, perf_id=self.c.PERF_ID,
+ perf_config=self.c.PERF_CONFIG)
else:
annotate = 'gtest'
- python_mode = False
test_type = test
flakiness_dash = (not self.m.tryserver.is_tryserver and
not self.m.chromium.c.runtests.memory_tool)
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/webrtc/steps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698