Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1882293003: 🐎 Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@wrapper-3
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts BUG=599919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -650 lines) Patch
M scripts/slave/recipe_modules/webrtc/steps.py View 3 chunks +7 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 13 chunks +14 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 13 chunks +14 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 13 chunks +14 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 13 chunks +14 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 13 chunks +14 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 13 chunks +13 lines, -39 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 13 chunks +13 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
agrieve
On 2016/04/13 00:22:37, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:kjellander@chromium.org the wrapper CL ...
4 years, 8 months ago (2016-04-13 01:27:05 UTC) #3
kjellander_chromium
lgtm. OK we'll wait for the other CL to reland then.
4 years, 8 months ago (2016-04-13 05:27:07 UTC) #4
kjellander_chromium
On 2016/04/13 05:27:07, kjellander (chromium) wrote: > lgtm. > OK we'll wait for the other ...
4 years, 8 months ago (2016-04-18 08:30:02 UTC) #5
agrieve
On 2016/04/18 08:30:02, kjellander (chromium) wrote: > On 2016/04/13 05:27:07, kjellander (chromium) wrote: > > ...
4 years, 8 months ago (2016-04-18 16:50:14 UTC) #6
kjellander_chromium
On 2016/04/18 16:50:14, agrieve wrote: > On 2016/04/18 08:30:02, kjellander (chromium) wrote: > > On ...
4 years, 8 months ago (2016-04-19 20:44:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882293003/1
4 years, 8 months ago (2016-04-21 16:45:37 UTC) #9
agrieve
On 2016/04/19 20:44:53, kjellander (chromium) wrote: > On 2016/04/18 16:50:14, agrieve wrote: > > On ...
4 years, 8 months ago (2016-04-21 16:45:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300083
4 years, 8 months ago (2016-04-21 16:49:16 UTC) #12
kjellander_chromium
4 years, 8 months ago (2016-04-22 12:11:06 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1913103002/ by kjellander@chromium.org.

The reason for reverting is: It seems the run_* scripts in WebRTC actually don't
include the timeouts yet, I will investigate before relanding this..

Powered by Google App Engine
This is Rietveld 408576698