Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1987203003: [Mac][Material Design] Add MD hover to bookmark items in menus. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@uploaded__bookmark_title_baseline_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Add MD hover to bookmark items in menus. The cl to update the bookmark bar to Material Design landed, but did not update the look of bookmark items in folder menus. R=avi@chromium.org BUG=612591 Committed: https://crrev.com/36c39b3f89c59537595d8f6da0dbfdcdac530957 Cr-Commit-Position: refs/heads/master@{#394621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-18 20:17:23 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-18 20:25:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987203003/1
4 years, 7 months ago (2016-05-18 23:36:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 00:49:34 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 00:52:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/36c39b3f89c59537595d8f6da0dbfdcdac530957
Cr-Commit-Position: refs/heads/master@{#394621}

Powered by Google App Engine
This is Rietveld 408576698