[Mac][Material Design] Add MD hover to bookmark items in menus.

chrome/browser/ui/cocoa/gradient_button_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/gradient_button_cell.h"
 
 #include <cmath>
 
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
@@ skipping 528 matching lines @@
       break;
   }
   if (type == kLeftButtonWithShadowType)
     innerFrame.size.width -= 1.0;
 
   // Return results if |return...| not null.
   if (returnInnerFrame)
     *returnInnerFrame = innerFrame;
   if (returnInnerPath) {
     DCHECK(*returnInnerPath == nil);
-    // In Material Design on Retina, nudge the hover background by 1px.
-    if ([self tag] == kMaterialStandardButtonTypeWithLimitedClickFeedback &&
-        kLineWidth < 1) {
-      drawFrame.origin.y -= kLineWidth;
-    }
+    drawFrame.origin.y +=
+        [self hoverBackgroundVerticalOffsetInControlView:controlView];
 
     *returnInnerPath = [NSBezierPath bezierPathWithRoundedRect:drawFrame
                                                        xRadius:cornerRadius
                                                        yRadius:cornerRadius];
     [*returnInnerPath setLineWidth:kLineWidth];
   }
   if (returnClipPath) {
     DCHECK(*returnClipPath == nil);
     NSRect clipPathRect =
         NSInsetRect(drawFrame, -kHalfLineWidth, -kHalfLineWidth);
@@ skipping 121 matching lines @@
                      fraction:[self isEnabled] ? 1.0 : 0.5
                respectFlipped:YES
                         hints:nil];
   }
 }
 
 - (int)verticalTextOffset {
   return 1;
 }
 
+- (CGFloat)hoverBackgroundVerticalOffsetInControlView:(NSView*)controlView {
+  return 0.0;
+}
+
 // Overriden from NSButtonCell so we can display a nice fadeout effect for
 // button titles that overflow.
 // This method is copied in the most part from GTMFadeTruncatingTextFieldCell,
 // the only difference is that here we draw the text ourselves rather than
 // calling the super to do the work.
 // We can't use GTMFadeTruncatingTextFieldCell because there's no easy way to
 // get it to work with NSButtonCell.
 // TODO(jeremy): Move this to GTM.
 - (NSRect)drawTitle:(NSAttributedString*)title
           withFrame:(NSRect)cellFrame
@@ skipping 129 matching lines @@
                              options:options
                                owner:self
                             userInfo:nil]);
   if (isMouseInside_ != mouseInView) {
     [self setMouseInside:mouseInView animate:NO];
     [controlView setNeedsDisplay:YES];
   }
 }
 
 @end