chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm - Issue 1987203003: [Mac][Material Design] Add MD hover to bookmark items in menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Issue 1987203003: [Mac][Material Design] Add MD hover to bookmark items in menus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@uploaded__bookmark_title_baseline_fix

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

index 6557848058251ae891453ee7c359b2aa40f31dab..e38e4a2d6261caba3c685c6d3c5e8f7c47e44907 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

@@ -12,6 +12,7 @@

#include "chrome/grit/generated_resources.h"

#import "components/bookmarks/browser/bookmark_model.h"

#include "content/public/browser/user_metrics.h"

+#import "ui/base/cocoa/nsview_additions.h"

#include "ui/base/l10n/l10n_util_mac.h"

#include "ui/base/material_design/material_design_controller.h"

#include "ui/base/resource/resource_bundle.h"

@@ -393,4 +394,16 @@ const int kDefaultFontSize = 12;

return -1;

}

+- (CGFloat)hoverBackgroundVerticalOffsetInControlView:(NSView*)controlView {

+ // In Material Design on Retina, and not in a folder menu, nudge the hover

+ // background by 1px.

+ const CGFloat kLineWidth = [controlView cr_lineWidth];

+ if ([self tag] == kMaterialStandardButtonTypeWithLimitedClickFeedback &&

+ ![self isFolderButtonCell] && kLineWidth < 1) {

+ return -kLineWidth;

+ }

+ return 0.0;

@end