[Net] Propagate priority changes from HttpNetworkTransaction to its request

[Net] Propagate priority changes from HttpNetworkTransaction to its request

Also propagate it further down to HttpStreamFactoryImpl::Job.

BUG=166689
R=mmenke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217582

[akalin, 2013-07-23 00:56:23]

+mmenke for review

[mmenke, 2013-07-23 18:33:33]

https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
net/http/http_network_transaction_unittest.cc:11755: EXPECT_EQ(MEDIUM,
request->priority());
Again, these requests that just write directly to the guts of a class, and get
it to a weird state that will never actually occur, seem to follow an
anti-pattern.

[akalin, 2013-08-09 18:53:35]

PTAL!

https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
net/http/http_network_transaction_unittest.cc:11755: EXPECT_EQ(MEDIUM,
request->priority());
On 2013/07/23 18:33:33, mmenke wrote:
> Again, these requests that just write directly to the guts of a class, and get
> it to a weird state that will never actually occur, seem to follow an
> anti-pattern.

Ah, I was missing HttpNetworkSessionPeer. Rewrote tests to use that instead.

[akalin, 2013-08-12 21:27:32]

On 2013/08/09 18:53:35, akalin wrote:
> PTAL!
> 
>
https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
> File net/http/http_network_transaction_unittest.cc (right):
> 
>
https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
> net/http/http_network_transaction_unittest.cc:11755: EXPECT_EQ(MEDIUM,
> request->priority());
> On 2013/07/23 18:33:33, mmenke wrote:
> > Again, these requests that just write directly to the guts of a class, and
get
> > it to a weird state that will never actually occur, seem to follow an
> > anti-pattern.
> 
> Ah, I was missing HttpNetworkSessionPeer. Rewrote tests to use that instead.

ping!

[mmenke, 2013-08-12 21:34:56]

On 2013/08/12 21:27:32, akalin wrote:
> On 2013/08/09 18:53:35, akalin wrote:
> > PTAL!
> > 
> >
>
https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
> > File net/http/http_network_transaction_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/19866006/diff/1/net/http/http_network_transac...
> > net/http/http_network_transaction_unittest.cc:11755: EXPECT_EQ(MEDIUM,
> > request->priority());
> > On 2013/07/23 18:33:33, mmenke wrote:
> > > Again, these requests that just write directly to the guts of a class, and
> get
> > > it to a weird state that will never actually occur, seem to follow an
> > > anti-pattern.
> > 
> > Ah, I was missing HttpNetworkSessionPeer. Rewrote tests to use that instead.
> 
> ping!

Sorry, took most of last week off, so a ton of reviews, and I'm sick today, so
going through them pretty slowly.  I'll try and get to it tomorrow.

[mmenke, 2013-08-14 14:46:34]

LGTM, modulo comments

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_request_unittest.cc (right):

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_request_unittest.cc:85:
request.AttachJob(job);
EXPECT_EQ(DEFAULT_PRIORITY, job->priority());?

Also, really should use MEDIUM here and above, rather than default priority,
rather than depending on DEFAULT_PRIORITY not being LOW.

[mmenke, 2013-08-14 14:46:34]

LGTM, modulo comments

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_request_unittest.cc (right):

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_request_unittest.cc:85:
request.AttachJob(job);
EXPECT_EQ(DEFAULT_PRIORITY, job->priority());?

Also, really should use MEDIUM here and above, rather than default priority,
rather than depending on DEFAULT_PRIORITY not being LOW.

[akalin, 2013-08-14 17:48:47]

Committing soon

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
File net/http/http_stream_factory_impl_request_unittest.cc (right):

https://codereview.chromium.org/19866006/diff/34001/net/http/http_stream_fact...
net/http/http_stream_factory_impl_request_unittest.cc:85:
request.AttachJob(job);
On 2013/08/14 14:46:34, mmenke wrote:
> EXPECT_EQ(DEFAULT_PRIORITY, job->priority());?
> 
> Also, really should use MEDIUM here and above, rather than default priority,
> rather than depending on DEFAULT_PRIORITY not being LOW.

Done.

[commit-bot: I haz the power, 2013-08-14 17:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/19866006/50001

[akalin, 2013-08-14 18:01:52]

Committed patchset #5 manually as r217582 (presubmit successful).

[mmenke, 2013-08-14 18:05:16]

https://chromiumcodereview.appspot.com/19866006/diff/50001/net/http/http_stre...
File net/http/http_stream_factory_impl_request_unittest.cc (right):

https://chromiumcodereview.appspot.com/19866006/diff/50001/net/http/http_stre...
net/http/http_stream_factory_impl_request_unittest.cc:86:
EXPECT_EQ(DEFAULT_PRIORITY, job->priority());
DEFAULT_PRIORITY should have been replaced, not LOW.  We should not rely on
DEFUALT_PRIORITY not being for the test to be correct