[Net] Propagate priority changes from HttpNetworkTransaction to its request

net/http/http_network_transaction_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <math.h>  // ceil
 #include <stdarg.h>
 #include <string>
 #include <vector>
@@ skipping 11661 matching lines @@
   rv = callback.WaitForResult();
   EXPECT_EQ(OK, rv);
 
   HttpRequestHeaders request_headers;
   EXPECT_TRUE(trans->GetFullRequestHeaders(&request_headers));
   std::string foo;
   EXPECT_TRUE(request_headers.GetHeader("X-Foo", &foo));
   EXPECT_EQ("bar", foo);
 }
 
+// Make sure that SetPriority actually sets the
+// HttpNetworkTransaction's priority.
+TEST_P(HttpNetworkTransactionTest, SetPriorityBasic) {
+  scoped_ptr<HttpNetworkTransaction> trans(
+      new HttpNetworkTransaction(
+          DEFAULT_PRIORITY, CreateSession(&session_deps_)));
+  EXPECT_EQ(DEFAULT_PRIORITY, trans->priority_);
+
+  trans->SetPriority(LOWEST);
+  EXPECT_EQ(LOWEST, trans->priority_);
+
+  trans->SetPriority(LOW);
+  EXPECT_EQ(LOW, trans->priority_);
+}
+
+namespace {
+
+// Fake HttpStreamRequest that simply records calls to SetPriority().
+class FakeStreamRequest : public HttpStreamRequest {
+ public:
+  FakeStreamRequest() : priority_(DEFAULT_PRIORITY) {}
+  virtual ~FakeStreamRequest() {}
+
+  RequestPriority priority() const { return priority_; }
+
+  virtual int RestartTunnelWithProxyAuth(
+      const AuthCredentials& credentials) OVERRIDE {
+    ADD_FAILURE();
+    return ERR_UNEXPECTED;
+  }
+
+  virtual LoadState GetLoadState() const OVERRIDE {
+    ADD_FAILURE();
+    return LoadState();
+  }
+
+  virtual void SetPriority(RequestPriority priority) OVERRIDE {
+    priority_ = priority;
+  }
+
+  virtual bool was_npn_negotiated() const OVERRIDE {
+    ADD_FAILURE();
+    return false;
+  }
+
+  virtual NextProto protocol_negotiated() const OVERRIDE {
+    ADD_FAILURE();
+    return kProtoUnknown;
+  }
+
+  virtual bool using_spdy() const OVERRIDE {
+    ADD_FAILURE();
+    return false;
+  }
+
+ private:
+  RequestPriority priority_;
+};
+
+}  // namespace
+
+// Make sure that HttpNetworkTransaction passes on its priority
+// updates to its stream request.
+TEST_P(HttpNetworkTransactionTest, SetStreamRequestPriority) {
+  scoped_ptr<HttpNetworkTransaction> trans(
+      new HttpNetworkTransaction(
+          DEFAULT_PRIORITY, CreateSession(&session_deps_)));
+  EXPECT_EQ(DEFAULT_PRIORITY, trans->priority_);
+
+  FakeStreamRequest* request = new FakeStreamRequest();
+  trans->stream_request_.reset(request);
+
+  trans->SetPriority(MEDIUM);
+  EXPECT_EQ(MEDIUM, request->priority());

[mmenke, 2013/07/23 18:33:33]

Again, these requests that just write directly to the guts of a class, and get
it to a weird state that will never actually occur, seem to follow an
anti-pattern.

[akalin, 2013/08/09 18:53:35]

Ah, I was missing HttpNetworkSessionPeer. Rewrote tests to use that instead.

+}
+
 }  // namespace net