[Net] Propagate priority changes from HttpNetworkTransaction to its request

net/http/http_stream_factory_impl_request_unittest.cc

Index: net/http/http_stream_factory_impl_request_unittest.cc
diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1f38a2e56f66474abfbabc7592429474cb66cea8
--- /dev/null
+++ b/net/http/http_stream_factory_impl_request_unittest.cc
@@ -0,0 +1,98 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_stream_factory_impl_request.h"
+
+#include "net/http/http_stream_factory_impl_job.h"
+#include "net/proxy/proxy_info.h"
+#include "net/proxy/proxy_service.h"
+#include "net/spdy/spdy_test_util_common.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+class HttpStreamFactoryImplRequestTest
+    : public ::testing::Test,
+      public ::testing::WithParamInterface<NextProto> {};
+
+INSTANTIATE_TEST_CASE_P(
+    NextProto,
+    HttpStreamFactoryImplRequestTest,
+    testing::Values(kProtoSPDY2, kProtoSPDY3, kProtoSPDY31, kProtoSPDY4a2,
+                    kProtoHTTP2Draft04));
+
+namespace {
+
+class DoNothingRequestDelegate : public HttpStreamRequest::Delegate {
+ public:
+  DoNothingRequestDelegate() {}
+
+  virtual ~DoNothingRequestDelegate() {}
+
+  // HttpStreamRequest::Delegate
+  virtual void OnStreamReady(
+      const SSLConfig& used_ssl_config,
+      const ProxyInfo& used_proxy_info,
+      HttpStreamBase* stream) OVERRIDE {}
+  virtual void OnWebSocketStreamReady(
+      const SSLConfig& used_ssl_config,
+      const ProxyInfo& used_proxy_info,
+      WebSocketStreamBase* stream) OVERRIDE {}
+  virtual void OnStreamFailed(
+      int status,
+      const SSLConfig& used_ssl_config) OVERRIDE {}
+  virtual void OnCertificateError(
+      int status,
+      const SSLConfig& used_ssl_config,
+      const SSLInfo& ssl_info) OVERRIDE {}
+  virtual void OnNeedsProxyAuth(const HttpResponseInfo& proxy_response,
+                                const SSLConfig& used_ssl_config,
+                                const ProxyInfo& used_proxy_info,
+                                HttpAuthController* auth_controller) OVERRIDE {}
+  virtual void OnNeedsClientAuth(const SSLConfig& used_ssl_config,
+                                 SSLCertRequestInfo* cert_info) OVERRIDE {}
+  virtual void OnHttpsProxyTunnelResponse(const HttpResponseInfo& response_info,
+                                          const SSLConfig& used_ssl_config,
+                                          const ProxyInfo& used_proxy_info,
+                                          HttpStreamBase* stream) OVERRIDE {}
+};
+
+}  // namespace
+
+// Make sure that Request passes on its priority updates to its jobs.
+TEST_P(HttpStreamFactoryImplRequestTest, SetPriority) {
+  SpdySessionDependencies session_deps(GetParam(),
+                                       ProxyService::CreateDirect());
+
+  scoped_refptr<HttpNetworkSession>
+      session(SpdySessionDependencies::SpdyCreateSession(&session_deps));
+  HttpStreamFactoryImpl* factory =
+      static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory());
+
+  DoNothingRequestDelegate request_delegate;
+  HttpStreamFactoryImpl::Request request(
+      GURL(), factory, &request_delegate, NULL, BoundNetLog());
+
+  HttpStreamFactoryImpl::Job* job =
+      new HttpStreamFactoryImpl::Job(factory,
+                                     session,
+                                     HttpRequestInfo(),
+                                     DEFAULT_PRIORITY,
+                                     SSLConfig(),
+                                     SSLConfig(),
+                                     NULL);
+  request.AttachJob(job);
+  EXPECT_EQ(DEFAULT_PRIORITY, job->priority());

[mmenke, 2013/08/14 18:05:16]

DEFAULT_PRIORITY should have been replaced, not LOW.  We should not rely on
DEFUALT_PRIORITY not being for the test to be correct

+
+  request.SetPriority(MEDIUM);
+  EXPECT_EQ(MEDIUM, job->priority());
+
+  // Make |job| the bound job.
+  request.OnStreamFailed(job, ERR_FAILED, SSLConfig());
+
+  request.SetPriority(IDLE);
+  EXPECT_EQ(IDLE, job->priority());
+}
+
+}  // namespace net