Make blurcircles2 run as a benchmark

Make blurcircles2 run as a benchmark.

In bench mode it does not draw the comparison paths (or line separators). It also randomly perturbs the blur and circle radii to avoid trivially hitting the same cache entries and each repetition.

BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1985713002

Committed: https://skia.googlesource.com/skia/+/2996553ba23212e345ba611772fcc6ee1574cb7e

[bsalomon, 2016-05-16 14:00:15]

Description was changed from

==========
Make blurcircles2 run as a benchmark

BUG=skia:5224
==========

to

==========
Make blurcircles2 run as a benchmark

BUG=skia:5224
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-16 14:06:19]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-05-16 14:10:47]

lgtm

[bsalomon, 2016-05-16 14:21:43]

Please take another look. The newest patchset add random perturbation of the
circle and blur radii that dramatically hurts GPU performance.

[bsalomon, 2016-05-16 14:23:08]

Description was changed from

==========
Make blurcircles2 run as a benchmark

BUG=skia:5224
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make blurcircles2 run as a benchmark.

In bench mode it does not draw the comparison paths (or line separators). It
also randomly perturbs the blur and circle radii to avoid trivially hitting the
same cache entries and each repetition.

BUG=skia:5224
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-16 14:26:30]

lgtm + a nit & a question

https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp
File gm/blurcircles2.cpp (right):

https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp#new...
gm/blurcircles2.cpp:102: for (int r = 0; r < kRadiusSteps; ++r) {
Should this kBlurRadiusSteps be kRadiusSteps ?
Would kDeltaBlurRadius & kDeltaRadius constants help ?

[bsalomon, 2016-05-16 14:43:57]

On 2016/05/16 14:26:30, robertphillips wrote:
> lgtm + a nit & a question
> 
> https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp
> File gm/blurcircles2.cpp (right):
> 
>
https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp#new...
> gm/blurcircles2.cpp:102: for (int r = 0; r < kRadiusSteps; ++r) {
> Should this kBlurRadiusSteps be kRadiusSteps ?
> Would kDeltaBlurRadius & kDeltaRadius constants help ?

Done and done.

[bsalomon, 2016-05-16 14:44:00]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-05-16 14:44:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1985713002/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2016-05-16 14:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 14:44:10]

This CL has an open dependency (Issue 1978253002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[bsalomon, 2016-05-16 16:16:39]

https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp
File gm/blurcircles2.cpp (right):

https://codereview.chromium.org/1985713002/diff/20001/gm/blurcircles2.cpp#new...
gm/blurcircles2.cpp:102: for (int r = 0; r < kRadiusSteps; ++r) {
On 2016/05/16 14:26:30, robertphillips wrote:
> Should this kBlurRadiusSteps be kRadiusSteps ?
> Would kDeltaBlurRadius & kDeltaRadius constants help ?

Done.

[bsalomon, 2016-05-16 16:16:44]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-05-16 16:16:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985713002/40001

[commit-bot: I haz the power, 2016-05-16 16:36:46]

Description was changed from

==========
Make blurcircles2 run as a benchmark.

In bench mode it does not draw the comparison paths (or line separators). It
also randomly perturbs the blur and circle radii to avoid trivially hitting the
same cache entries and each repetition.

BUG=skia:5224
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make blurcircles2 run as a benchmark.

In bench mode it does not draw the comparison paths (or line separators). It
also randomly perturbs the blur and circle radii to avoid trivially hitting the
same cache entries and each repetition.

BUG=skia:5224
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2996553ba23212e345ba611772fcc6ee1574cb7e
==========

[commit-bot: I haz the power, 2016-05-16 16:36:47]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2996553ba23212e345ba611772fcc6ee1574cb7e