Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1981923002: Reformat circle blur profile computation and add comments. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@blurbench
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : compute offset always #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -43 lines) Patch
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 2 5 chunks +61 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
bsalomon
4 years, 7 months ago (2016-05-16 16:13:49 UTC) #3
robertphillips
lgtm
4 years, 7 months ago (2016-05-16 16:17:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981923002/40001
4 years, 7 months ago (2016-05-18 13:55:32 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:15:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3ab53d0c778704111a72b7107154ade4aa536232

Powered by Google App Engine
This is Rietveld 408576698