PDF: Use custom iconsets instead of iron-icons

PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077
Cr-Commit-Position: refs/heads/master@{#393801}

[tsergeant, 2016-05-16 01:26:14]

Description was changed from

==========
PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
==========

to

==========
PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-05-16 01:55:57]

tsergeant@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tsergeant, 2016-05-16 01:55:58]

PTAL. I've moved 5 icons from settings to cr since they're used in both settings
and PDF. Let me know if you'd prefer to keep them separate.

[michaelpg, 2016-05-16 04:21:16]

so far so good, i think you forgot to git add the icons.html though?

[tsergeant, 2016-05-16 04:35:17]

oooooops, done.

[michaelpg, 2016-05-16 04:43:35]

thank you! lgtm

https://codereview.chromium.org/1985573002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/icons.html (right):

https://codereview.chromium.org/1985573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/icons.html:10:
https://poly-icon.appspot.com/?name=pdf&size=24&icon=icons%3Aadd&icon=icons%3...
nit: s/%3A/:/g for legibility

[tsergeant, 2016-05-16 04:53:01]

https://codereview.chromium.org/1985573002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/icons.html (right):

https://codereview.chromium.org/1985573002/diff/40001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/icons.html:10:
https://poly-icon.appspot.com/?name=pdf&size=24&icon=icons%3Aadd&icon=icons%3...
On 2016/05/16 04:43:35, michaelpg wrote:
> nit: s/%3A/:/g for legibility

Done.

[tsergeant, 2016-05-16 04:53:12]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-05-16 04:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1985573002/#ps60001
(title: "%3A -> :")

[commit-bot: I haz the power, 2016-05-16 04:53:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985573002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985573002/60001

[commit-bot: I haz the power, 2016-05-16 05:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 05:27:23]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[tsergeant, 2016-05-16 05:50:37]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-05-16 05:50:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1985573002/#ps80001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-05-16 05:50:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985573002/80001

[commit-bot: I haz the power, 2016-05-16 06:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 06:06:24]

Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tsergeant, 2016-05-16 06:29:37]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-05-16 06:29:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985573002/80001

[commit-bot: I haz the power, 2016-05-16 07:16:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-16 07:17:59]

Description was changed from

==========
PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077
Cr-Commit-Position: refs/heads/master@{#393801}
==========

[commit-bot: I haz the power, 2016-05-16 07:18:00]

Patchset 5 (id:??) landed as
https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077
Cr-Commit-Position: refs/heads/master@{#393801}