Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5161)

Unified Diff: chrome/test/data/pdf/material_elements_test.js

Issue 1985573002: PDF: Use custom iconsets instead of iron-icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/icons.html ('k') | ui/webui/resources/cr_elements/icons.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/pdf/material_elements_test.js
diff --git a/chrome/test/data/pdf/material_elements_test.js b/chrome/test/data/pdf/material_elements_test.js
index 8ec88b2acfd38758951cdf8016dc833ea89accef..60bc2298c198133d161f5c11b541bc13ab9fa223 100644
--- a/chrome/test/data/pdf/material_elements_test.js
+++ b/chrome/test/data/pdf/material_elements_test.js
@@ -160,17 +160,20 @@ var tests = [
zoomToolbar.addEventListener('fit-to-page', logEvent);
// Initial: Show fit-to-page.
- chrome.test.assertEq(fitPageIcon, fab.icon);
+ // TODO(tsergeant): This assertion attempts to be resilient to iconset
+ // changes. A better solution is something like
+ // https://github.com/PolymerElements/iron-icon/issues/68.
+ chrome.test.assertTrue(fab.icon.endsWith(fitPageIcon));
// Tap 1: Fire fit-to-page, show fit-to-width.
MockInteractions.tap(fab);
assertEvent('fit-to-page');
- chrome.test.assertEq(fitWidthIcon, fab.icon);
+ chrome.test.assertTrue(fab.icon.endsWith(fitWidthIcon));
// Tap 2: Fire fit-to-width, show fit-to-page.
MockInteractions.tap(fab);
assertEvent('fit-to-width');
- chrome.test.assertEq(fitPageIcon, fab.icon);
+ chrome.test.assertTrue(fab.icon.endsWith(fitPageIcon));
// Tap 3: Fire fit-to-page again.
MockInteractions.tap(fab);
« no previous file with comments | « chrome/browser/resources/settings/icons.html ('k') | ui/webui/resources/cr_elements/icons.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698