Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1982113002: MD Settings: Fix names of icons which had been moved to shared iconset (Closed)

Created:
4 years, 7 months ago by tsergeant
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_icons
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix names of icons which had been moved to shared iconset In crrev.com/393801, several icons from the settings iconset were moved to the shared cr iconset, however, the icon names in MD Settings were not updated. This CL updates the icons so they display correctly again. BUG=605821 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70 Cr-Commit-Position: refs/heads/master@{#394007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
tsergeant
PTAL, thanks for pointing this out
4 years, 7 months ago (2016-05-16 23:41:15 UTC) #3
dschuyler
lgtm
4 years, 7 months ago (2016-05-17 00:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982113002/1
4 years, 7 months ago (2016-05-17 00:35:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:29:12 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:31:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70
Cr-Commit-Position: refs/heads/master@{#394007}

Powered by Google App Engine
This is Rietveld 408576698