Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1985503002: Make x86 linux use gold by default again after android revert. (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
Menglin
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make x86 linux use gold by default again after android revert. The revert of the Android gold change in r393738 also partially reverted the change to using gold on x86 linux in r393645. This CL re-lands the x86 linux part. TBR=mlliu@chromium.org BUG=590004, 611618, 606749 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_compile_dbg_32_ng,linux_chromium_dbg_32_ng Committed: https://crrev.com/665f2abb04029e72a8852a2ecb0959031272ff25 Cr-Commit-Position: refs/heads/master@{#393759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
4 years, 7 months ago (2016-05-14 21:24:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985503002/1
4 years, 7 months ago (2016-05-14 21:25:32 UTC) #4
Nico
On 2016/05/14 21:25:32, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-14 21:51:16 UTC) #5
Dirk Pranke
On 2016/05/14 21:51:16, Nico wrote: > On 2016/05/14 21:25:32, commit-bot: I haz the power wrote: ...
4 years, 7 months ago (2016-05-14 23:27:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-15 01:24:23 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/665f2abb04029e72a8852a2ecb0959031272ff25 Cr-Commit-Position: refs/heads/master@{#393759}
4 years, 7 months ago (2016-05-15 01:27:07 UTC) #11
Menglin
4 years, 7 months ago (2016-05-16 16:04:35 UTC) #12
Message was sent while issue was closed.
On 2016/05/15 01:27:07, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/665f2abb04029e72a8852a2ecb0959031272ff25
> Cr-Commit-Position: refs/heads/master@{#393759}

lgtm

Powered by Google App Engine
This is Rietveld 408576698