Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1984473002:
[Telemetry] Add BattOr benchmark. (Closed)
|
Created:
4 years, 7 months ago by rnephew (Reviews Here) Modified:
4 years, 6 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Telemetry] Add BattOr benchmark.
BUG=574888
Committed: https://crrev.com/21bd980e0548fbd01e4bf709ebba0b08ddd5da25
Cr-Commit-Position: refs/heads/master@{#396642}
Patch Set 1 : #
Total comments: 6
Patch Set 2 : #
Total comments: 21
Patch Set 3 : #
Total comments: 4
Patch Set 4 : #Patch Set 5 : #
Total comments: 2
Patch Set 6 : #
Total comments: 5
Patch Set 7 : #
Total comments: 4
Patch Set 8 : #
Total comments: 3
Patch Set 9 : #
Messages
Total messages: 52 (16 generated)
Description was changed from ========== [Telemetry] Add BattOr benchmark. BUG=574888 ========== to ========== [Telemetry] Add BattOr benchmark. BUG=574888 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
rnephew@chromium.org changed reviewers: + charliea@chromium.org, nednguyen@google.com
https://codereview.chromium.org/1984473002/diff/40001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/40001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:24: return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name You can add: "ShouldTearDownStateAfterEachStoryRun" to return False here. https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... File tools/perf/page_sets/battor_cases.py (right): https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... tools/perf/page_sets/battor_cases.py:10: 'https://webkit.org/blog-files/3d-transforms/poster-circle.html' also youtube & about:blank? https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... tools/perf/page_sets/battor_cases.py:14: class BattOrCasesPage(page_module.Page): s/BattOrCasesPage/PowerCasesPage
https://codereview.chromium.org/1984473002/diff/40001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/40001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:24: return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name On 2016/05/16 16:22:18, nednguyen wrote: > You can add: "ShouldTearDownStateAfterEachStoryRun" to return False here. Done. https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... File tools/perf/page_sets/battor_cases.py (right): https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... tools/perf/page_sets/battor_cases.py:10: 'https://webkit.org/blog-files/3d-transforms/poster-circle.html' On 2016/05/16 16:22:19, nednguyen wrote: > also youtube & about:blank? Done. https://codereview.chromium.org/1984473002/diff/40001/tools/perf/page_sets/ba... tools/perf/page_sets/battor_cases.py:14: class BattOrCasesPage(page_module.Page): On 2016/05/16 16:22:18, nednguyen wrote: > s/BattOrCasesPage/PowerCasesPage Done. Also changed the other instances to Power*
https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:10: class _BattOrBenchmark(perf_benchmark.PerfBenchmark): Same note here as I have in the other CL: this isn't a BattOr benchmark; it's a power benchmark that happens to pull data from a BattOr (several links in the chain away). That'll help with discoverability of this directory for newbies down the road. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:22: # http://crbug.com/600463 nit: I usually see crbugs in comments used as a sort of "further reading" source. like: "This benchmark is disabled on Samsung Galaxy S5s due to known issues with disabling charging. See http://crbug.com/600463.' https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): s/Ter/Tear https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... File tools/perf/page_sets/power_cases.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. nit: s/2014/2016 https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. I think it makes sense to create our own directory, power_cases, to mirror all of the other .+_cases directories https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:3: # found in the LICENSE file. nit: blank line after license https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:11: # Does not autoplay on android devices. s/android/Android
https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:10: class _BattOrBenchmark(perf_benchmark.PerfBenchmark): On 2016/05/16 19:30:21, charliea wrote: > Same note here as I have in the other CL: this isn't a BattOr benchmark; it's a > power benchmark that happens to pull data from a BattOr (several links in the > chain away). > > That'll help with discoverability of this directory for newbies down the road. As written these are literally only battor benchmarks since they disable chrome tracing and enable battor tracing. I think they should be renamed later, when we get Chrome tracing working well with battor tracing. Currently, the clock sync issue is arising when I look at the trace in trace_viewer. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:22: # http://crbug.com/600463 On 2016/05/16 19:30:21, charliea wrote: > nit: I usually see crbugs in comments used as a sort of "further reading" > source. > > like: "This benchmark is disabled on Samsung Galaxy S5s due to known issues with > disabling charging. See http://crbug.com/600463. Done. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): On 2016/05/16 19:30:21, charliea wrote: > s/Ter/Tear Done. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... File tools/perf/page_sets/power_cases.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. On 2016/05/16 19:30:21, charliea wrote: > I think it makes sense to create our own directory, power_cases, to mirror all > of the other .+_cases directories Those subdirectories look like they mostly contain html pages. Since this contains no html, I do not think it makes sense at this moment to do that. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. On 2016/05/16 19:30:21, charliea wrote: > nit: s/2014/2016 Done. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:3: # found in the LICENSE file. On 2016/05/16 19:30:21, charliea wrote: > nit: blank line after license Done. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:11: # Does not autoplay on android devices. On 2016/05/16 19:30:21, charliea wrote: > s/android/Android Done.
lgtm w/ nits (please hold for ned's lgtm also, as he has a whole heck of a lot more idea of how to write a Telemetry test than I do) https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:10: class _BattOrBenchmark(perf_benchmark.PerfBenchmark): On 2016/05/16 20:05:57, rnephew1 wrote: > On 2016/05/16 19:30:21, charliea wrote: > > Same note here as I have in the other CL: this isn't a BattOr benchmark; it's > a > > power benchmark that happens to pull data from a BattOr (several links in the > > chain away). > > > > That'll help with discoverability of this directory for newbies down the road. > > As written these are literally only battor benchmarks since they disable chrome > tracing and enable battor tracing. I think they should be renamed later, when we > get Chrome tracing working well with battor tracing. Currently, the clock sync > issue is arising when I look at the trace in trace_viewer. Acknowledged. https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): nit: you can delete this. it's the default implementation see: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu... https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... File tools/perf/page_sets/power_cases.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. On 2016/05/16 20:05:57, rnephew1 wrote: > On 2016/05/16 19:30:21, charliea wrote: > > nit: s/2014/2016 > > Done. It looks like https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_se... contains only .py files, but still has its own subdirectory. If we know that we're going to have more power test cases in the future, why create more work for ourselves by not placing it there now? Isn't the first person to write a second benchmark going to have to go back and rewire the imports to reflect the new directory? https://codereview.chromium.org/1984473002/diff/60001/tools/perf/page_sets/po... tools/perf/page_sets/power_cases.py:11: # Does not autoplay on android devices. On 2016/05/16 20:05:57, rnephew1 wrote: > On 2016/05/16 19:30:21, charliea wrote: > > s/android/Android > > Done. Is the lack of autoplay going to be a problem on Android devices? (I guess we don't have any Android devices w/ BattOrs right now, so it's definitely not a blocker) https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:22: # Galaxy s5s have problems with running system health metrics. nit: s/s5s/S5s http://www.amazon.com/Samsung-Galaxy-S5-White-Sprint/dp/B00IZ1X21K
lg2me but you need to record & upload the web-page-replay recording using tools/perf/record_wpr <battor_benchmark_name> ---upload https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:29: return False nits: 2 blank line here
https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): On 2016/05/17 13:44:26, charliea wrote: > nit: you can delete this. it's the default implementation > > see: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu... Ned specifically asked me to add this, so interested in his reasoning before I get rid of it. https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:22: # Galaxy s5s have problems with running system health metrics. On 2016/05/17 13:44:26, charliea wrote: > nit: s/s5s/S5s > > http://www.amazon.com/Samsung-Galaxy-S5-White-Sprint/dp/B00IZ1X21K Done. https://codereview.chromium.org/1984473002/diff/80001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:29: return False On 2016/05/17 14:26:02, nednguyen wrote: > nits: 2 blank line here Done.
https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): On 2016/05/17 16:18:03, rnephew (Reviews Here) wrote: > On 2016/05/17 13:44:26, charliea wrote: > > nit: you can delete this. it's the default implementation > > > > see: > > > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu... > > Ned specifically asked me to add this, so interested in his reasoning before I > get rid of it. What I meant is we override this to return True so that the benchmark restarts the browser between each page run here :-)
https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/60001/tools/perf/benchmarks/b... tools/perf/benchmarks/battor.py:27: def ShouldTerDownStateAfterEachStoryRun(cls): On 2016/05/17 17:17:56, nednguyen wrote: > On 2016/05/17 16:18:03, rnephew (Reviews Here) wrote: > > On 2016/05/17 13:44:26, charliea wrote: > > > nit: you can delete this. it's the default implementation > > > > > > see: > > > > > > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapu... > > > > Ned specifically asked me to add this, so interested in his reasoning before I > > get rid of it. > > What I meant is we override this to return True so that the benchmark restarts > the browser between each page run here :-) Changed to return true.
lgtm but please upload the pages recording
oops, still need to disable benchmark on non battor devices https://codereview.chromium.org/1984473002/diff/120001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/120001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:21: def ShouldDisable(cls, browser): Also we should disable this on bots that don't have battor. You can use the IsBattorDeviceConnected() for the check
https://codereview.chromium.org/1984473002/diff/120001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/120001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:21: def ShouldDisable(cls, browser): On 2016/05/17 17:40:22, nednguyen wrote: > Also we should disable this on bots that don't have battor. You can use the > IsBattorDeviceConnected() for the check Done. https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:14: BATTOR_PATH = os.path.join( Is there a better place to add this to the python path? I originally did it in run_benchmark, but then that caused problems with WPR recording since it wasn't in the path there.
Sorry but we need another telemetry CL before landing this https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:14: BATTOR_PATH = os.path.join( On 2016/05/17 18:54:16, rnephew (Reviews Here) wrote: > Is there a better place to add this to the python path? I originally did it in > run_benchmark, but then that caused problems with WPR recording since it wasn't > in the path there. Here is ok. Ideally, the tools/perf should follow the double-project-name (tools/perf/perf) folder of our python projects & we add the BATTOR_PATH to tools/perf/perf/__init__.py but it's now super annoying to do this refactoring https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:34: device = (browser.platform._platform_backend.device Accessing _platform_backend here violates the private API contract. Can you make a CL that creates a platform.IsBattorConnected() method on telemetry side?
https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:34: device = (browser.platform._platform_backend.device On 2016/05/18 02:15:17, nednguyen wrote: > Accessing _platform_backend here violates the private API contract. Can you make > a CL that creates a platform.IsBattorConnected() method on telemetry side? err, sorry. Let's name it platform.HasBattorConnected() :-)
https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/140001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:34: device = (browser.platform._platform_backend.device On 2016/05/18 02:17:07, nednguyen wrote: > On 2016/05/18 02:15:17, nednguyen wrote: > > Accessing _platform_backend here violates the private API contract. Can you > make > > a CL that creates a platform.IsBattorConnected() method on telemetry side? > > err, sorry. Let's name it platform.HasBattorConnected() :-) Done. Needs https://codereview.chromium.org/1997633003/ to land.
All CLs this rely on have landed (though still likely need to go through the catapult roller).
On 2016/05/19 19:53:48, rnephew (Reviews Here) wrote: > All CLs this rely on have landed (though still likely need to go through the > catapult roller). This probably is ready to update & reland
On 2016/05/25 16:09:25, nednguyen wrote: > On 2016/05/19 19:53:48, rnephew (Reviews Here) wrote: > > All CLs this rely on have landed (though still likely need to go through the > > catapult roller). > > This probably is ready to update & reland I'm not sure this requires any changes before its looked at again.
https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:21: def ShouldDisable(cls, browser): this is possible_browser
lgtm with 2 comments https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.py File tools/perf/PRESUBMIT.py (right): https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.p... tools/perf/PRESUBMIT.py:35: battor_dir = input_api.os_path.join( We no longer need this change
https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.py File tools/perf/PRESUBMIT.py (right): https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.p... tools/perf/PRESUBMIT.py:35: battor_dir = input_api.os_path.join( On 2016/05/25 19:50:11, nednguyen wrote: > We no longer need this change Done. https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:21: def ShouldDisable(cls, browser): On 2016/05/25 17:55:24, nednguyen wrote: > this is possible_browser Done.
On 2016/05/25 20:41:31, rnephew (Reviews Here) wrote: > https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.py > File tools/perf/PRESUBMIT.py (right): > > https://codereview.chromium.org/1984473002/diff/160001/tools/perf/PRESUBMIT.p... > tools/perf/PRESUBMIT.py:35: battor_dir = input_api.os_path.join( > On 2016/05/25 19:50:11, nednguyen wrote: > > We no longer need this change > > Done. > > https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... > File tools/perf/benchmarks/battor.py (right): > > https://codereview.chromium.org/1984473002/diff/160001/tools/perf/benchmarks/... > tools/perf/benchmarks/battor.py:21: def ShouldDisable(cls, browser): > On 2016/05/25 17:55:24, nednguyen wrote: > > this is possible_browser > > Done. lgtm I think this is ready to land :-)
The CQ bit was checked by rnephew@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from charliea@chromium.org Link to the patchset: https://codereview.chromium.org/1984473002/#ps180001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984473002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984473002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/05/25 22:00:32, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) This seems to be a bug in benchmark_smoke_unittest, I will take a look
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984473002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984473002/180001
The CQ bit was unchecked by nednguyen@google.com
https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:17: options.SetTimelineBasedMetric('SystemHealthMetrics') this should be powerMetric.
https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:17: options.SetTimelineBasedMetric('SystemHealthMetrics') On 2016/05/27 19:40:40, nednguyen wrote: > this should be powerMetric. Let wait for https://codereview.chromium.org/2011403002/ to land & rename this to powerMetric
Also reuploaded pageset for desktop version of sites. https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/1984473002/diff/180001/tools/perf/benchmarks/... tools/perf/benchmarks/battor.py:17: options.SetTimelineBasedMetric('SystemHealthMetrics') On 2016/05/27 19:40:40, nednguyen wrote: > this should be powerMetric. Done.
Also reuploaded pageset for desktop version of sites.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, charliea@chromium.org Link to the patchset: https://codereview.chromium.org/1984473002/#ps200001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984473002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984473002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== [Telemetry] Add BattOr benchmark. BUG=574888 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== [Telemetry] Add BattOr benchmark. BUG=574888 ==========
The CQ bit was checked by nednguyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984473002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984473002/200001
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Add BattOr benchmark. BUG=574888 ========== to ========== [Telemetry] Add BattOr benchmark. BUG=574888 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Add BattOr benchmark. BUG=574888 ========== to ========== [Telemetry] Add BattOr benchmark. BUG=574888 Committed: https://crrev.com/21bd980e0548fbd01e4bf709ebba0b08ddd5da25 Cr-Commit-Position: refs/heads/master@{#396642} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/21bd980e0548fbd01e4bf709ebba0b08ddd5da25 Cr-Commit-Position: refs/heads/master@{#396642} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
